gocast icon indicating copy to clipboard operation
gocast copied to clipboard

Worker doesn't gracefully shut down

Open joschahenningsen opened this issue 2 years ago • 0 comments

Describe the bug When a worker is handling a stream and receives a SIGTERM it shuts down which also kills the running livestream.

To Reproduce Steps to reproduce the behavior:

  1. start a stream
  2. restart the worker e.g. by using docker service deploy --force live_worker
  3. -> stream stops playing

Expected behavior Upon receiving a SIGTERM, the worker should not accept further stream requests and stop as soon as all running jobs are completed.

Additional context Paired with dockers stop_grace_period we can use rolling upgrades without downtime.

joschahenningsen avatar Oct 01 '22 11:10 joschahenningsen