gocast icon indicating copy to clipboard operation
gocast copied to clipboard

Published 20 hours ago • verified publisher icon TUM-Dev

Multiple Synced Players

Open ata-keskin opened this issue 2 years ago • 1 comments

Motivation and Context

Adds multiple synced players as a viewing option. The current split-view implementation is very primitive and could be enhanced in a later PR. An example off the top of my head: Show the chat below the CAM version for a bigger PRES stream.

Description

Adds View Version STEP with a ratio-picker with predefined ratios. (3:1, 1:1, 1:3)

Steps for Testing

  1. Navigate to a livestream which has a PRES and a CAM version
  2. Click on the split-view button in the actions-bar. You will be redirect to .../SPLIT
  3. Hovering over the video makes the ratio-picker visible
  4. Choose a ratio
  5. Make sure to test CAM, PRES, and COMB on its own
  6. Make sure to test the chat replay

Screenshots

Screenshot 2022-10-17 at 13 54 16 Screenshot 2022-10-17 at 13 54 01

ata-keskin avatar Jul 22 '22 11:07 ata-keskin

Can you fix the CI issues? If it is not possible, you can also surpress the issues.

alexanderstephan avatar Jul 22 '22 12:07 alexanderstephan

I'm in love with this!

I noticed however that sometimes both videos are unmuted which sounds weird. Ideally the camera version should be unmuted and the presentation should be muted. I don't know how to handle unmuting and muting the video when the presentation has focus tho...

joschahenningsen avatar Dec 11 '22 13:12 joschahenningsen

I deployed this today for testing and it seems like it breaks the embed: https://github.com/joschahenningsen/TUM-Live/issues/844

joschahenningsen avatar Dec 11 '22 16:12 joschahenningsen

I deployed this today for testing and it seems like it breaks the embed: #844

I will have a look at the sound and embedded player problems tomorrow. Thanks for pointing out!

MatthiasReumann avatar Dec 11 '22 17:12 MatthiasReumann

I deployed this today for testing and it seems like it breaks the embed: #844

The issues should be fixed now. Thanks again! I guess that's what happens when you test everything on mute 🫠

MatthiasReumann avatar Dec 12 '22 06:12 MatthiasReumann