gocast icon indicating copy to clipboard operation
gocast copied to clipboard

840 short description for each video

Open karjo24 opened this issue 10 months ago • 4 comments

Motivation and Context

#840. Having the ability to make short notes or add/change the title of the lecture is useful for organising lectures when titles are not provided by the course admins.

Description

There's an additional option in the dropdown menu for each stream on the course overview page that allows users to input their own (limited to 80 characters) lecture title. There's a new API endpoint, that takes the new title and stores it in a new table in the database.

Steps for Testing

Prerequisites:

  • 1 User
  • 1 Course with 1 stream with title, 1 stream without
  1. Log in and navigate to course
  2. Click on the "More options" menu (three dots next to stream)
  3. Click on "Edit personal lecture title"
  4. Enter new title in popup menu
  5. Verify the following behaviour 5.1 Pressing "Enter" or clicking outside the input field changes the title 5.2 Pressing "Escape" disregards any changes 5.3 Deleting the value of the input field resets the title to the actual title provided by the lecturer
  6. Reload to make sure the changes are persistent

Screenshots

https://github.com/user-attachments/assets/d8adfd72-19e3-43b7-ab91-e7ec0bc55373

karjo24 avatar Mar 08 '25 14:03 karjo24

* Should the personal lecture title be displayed only in the course-view, or also in the "Recent VODs" and videoplayer/stream-view?

Yes, thanks for catching that. Somehow thought the title was not displayed there and didn't check. I'll change that.

* Should lecturers/admins of a course be allowed to add personal lecture titles, or would it be better to have the button set the actual lecture title to avoid confusion?

It probably shouldn't be left like this as I agree with the confusion part. I'm not sure, whether we should hide the menu option for admins or make it change the title globally. After all, that's what the admin page is for. I lean towards the "hide it"-approach, but I'm open for other opinions.

karjo24 avatar Mar 09 '25 21:03 karjo24

It probably shouldn't be left like this as I agree with the confusion part. I'm not sure, whether we should hide the menu option for admins or make it change the title globally. After all, that's what the admin page is for. I lean towards the "hide it"-approach, but I'm open for other opinions.

I think we can leave it out for now and add it in the future in a separate PR if necessary.

carlobortolan avatar Mar 11 '25 13:03 carlobortolan

Maybe there should also be a button for the user to delete the custom title, as just removing it to reset it to the lecturers title may not be intuitive.

SebiWrn avatar Mar 18 '25 16:03 SebiWrn

  • Should the personal lecture title be displayed only in the course-view, or also in the "Recent VODs" and videoplayer/stream-view?

Yes, thanks for catching that. Somehow thought the title was not displayed there and didn't check. I'll change that.

I'd postpone this change as this would require changing the signature of two methods, which are heavily used throughout the project, which would inflate this PR.

karjo24 avatar Mar 21 '25 10:03 karjo24