1291 split view progress bar in wrong position after entering fullscreen mode if the width ratio of two views adjusted
Motivation and Context
See Issue #1291.
Description
Adjusting size of players in splitview when in fullscreen mode (or vice versa) doesn't result in the control bar being in the wrong position anymore. This applies to subtitles as well. Currently, the control bar of the right video player is used as the control bar for both video players, the one on the left is hidden. This results in said weird issues as the control bar has to have (potentially high) negative left margins. As I couldn't figure out what exactly is the issue with updating the left margin, this is fixed by switching roles of the two control bars (left is "global" control bar, right is hidden). This may have side effects! Only side effect known to me is that the subtitle settings menu is now an overlay of the left video player (instead of the right player).
Steps for Testing
Prerequisites:
- 1 Livestream / VOD (preferably with subtitles)
- Navigate to a Livestream
- Play around by adjusting sizes and toggling fullscreen mode.
- See no errors.
Your Testserver will be ready at https://1393.test.live.mm.rbg.tum.de in a few minutes.
Logins
| Kurs1 | Kurs2 | Kurs3 | Kurs4 |
|---|---|---|---|
| public | public | loggedin | enrolled |
| prof1 | prof1 | prof2 | prof1 prof2 |
| student1 student2 student3 |
student1 student2 |
student2 student3 |
student1 student2 |
This may have side effects! Only side effect known to me is that the subtitle settings menu is now an overlay of the left video player (instead of the right player).
This one and only side effect is irrelevant imo and as far as I can tell, but I my have missed something. I'd guess, that there was a reason for choosing the non-straight-forward solution of making the right control bar the main control bar, but I haven't found anything plausible yet. This may be on me though. If anyone knows more, let me know.