eat-api icon indicating copy to clipboard operation
eat-api copied to clipboard
verified publisher icon TUM-Dev

Also translate dish type into English

Open Friendly-Banana opened this issue 1 year ago • 3 comments

Friendly-Banana avatar Jul 25 '24 17:07 Friendly-Banana

@Friendly-Banana sounds like a really good idea. Any chance you would like to work on a PR for it?

COM8 avatar Aug 08 '24 15:08 COM8

Yes, but I'm not so familiar with the codebase. How would I go about adding this? There seem to be multiple partial DishType collections: FMIBistroMenuParser.DishType https://github.com/TUM-Dev/eat-api/blob/01a2703104736872be191ccc3a04df72e94df3ad/src/menu_parser.py#L312 https://github.com/TUM-Dev/eat-api/blob/01a2703104736872be191ccc3a04df72e94df3ad/src/menu_parser.py#L743 https://github.com/TUM-Dev/eat-api/blob/01a2703104736872be191ccc3a04df72e94df3ad/src/menu_parser.py#L899

Friendly-Banana avatar Aug 11 '24 21:08 Friendly-Banana

Basically yes. There is not really more to it.

COM8 avatar Aug 17 '24 12:08 COM8