Campus-Android
Campus-Android copied to clipboard
TUM-Dev
Old feature: room schedule
Problem
Working on migration from RoomFinder to NavigaTUM API, I came across code that is not possible to use by the end user. It looks like that logic was showing the room schedule for the chosen room.
I find out that this logic was not available to execute after these two commits:
In both these commits, it looks like this might be done accidentally, but cannot be sure. However, it looks like, since April 2018 this RoomFinder schedule feature does not work, therefore I decided to make a separate issue for that instead of fixing it in migration PR. Also since it was not available for so long, there is a question if anybody needs it.
How do I think it was working back then? Firstly it was fetching schedules (RoomFinderSchedule) using TUMCabeClient.fetchSchedule() method in WeekViewFragment and then this fragment was attached to the RoomFinderDetailsActivity, so the user could choose it. All that can be found by looking at these two commits I linked.
Remarks
After migration to NavigaTUM API, there is a new screen (NavigationDetailsFragment) that displays room details instead of RoomFinderDetailsActivity. RoomFinderDetailsActivity is not used anymore, however, I haven't removed it because one might find it useful in order to reimplement room schedule logic.
More info in conversation in migration to NavigaTUM PR https://github.com/TUM-Dev/Campus-Android/pull/1462
Suggested solutions :sparkles:
- Since it was not working for so long maybe nobody needs it, so if we don't wanna fix it, this code should be removed. I mean:
-
RoomFinderDetailsActivity(I haven't removed this only because of this issue), -
WeekViewFragment, -
TUMCabeClient.fetchSchedule(), -
RoomFinderSchedule, - and any additional logic connected with these.
-
- Reimplement it in the new room details screen NavigationDetailsFragment. In this case, remove only legacy
RoomFinderDetailsActivity.
