Campus-Android icon indicating copy to clipboard operation
Campus-Android copied to clipboard

DeviceUploadFcmToken not yet using standardized authentication

Open kordianbruck opened this issue 6 years ago • 2 comments

I've just checked my devices in the database and none of them have a gcmToken set. Seems there is a bug with uploading it.

kordianbruck avatar Nov 01 '18 21:11 kordianbruck

I recently rewrote the FcmTokenHandler, maybe there was a regression with those changes?

Can you search your device logs for any log messages?

pfent avatar Nov 01 '18 21:11 pfent

You are lucky - its not your change :sparkles:

I figured out, we actually have a third structure to authenticate requests from the client. https://github.com/TUM-Dev/Campus-Android/blob/dd69f99c04152fdc0d29e661a22ee78bb5d4e75a/app/src/main/java/de/tum/in/tumcampusapp/api/app/model/DeviceUploadFcmToken.kt

When we reworte auth in the backend, I was not aware of this. That DeviceUploadFcmToken should actually just use TUMCabeVerification and its data field.

kordianbruck avatar Nov 01 '18 21:11 kordianbruck