Q3Map2 bug: q3map_lightmapSize + q3map_styleMarker references incorrect lightmap textures

[SoS-XZ]

trafficstars

Hi. So I ran into a q3map2 bug where the $lightmap references point to the wrong lightmap textures when q3map_lightmapSize is used in combination with q3map_styleMarker. I tested it against OpenArena 0.8.8 and ioq3 engines with similar results.

If you can, please change the q3map2 parser that generates the map specific shader file so that it resolves all $lightmap references to the external texture references when tcgen lightmap is used e.g. maps/shadertest1/lm_xxxx.tga instead. I substituted $lightmap with the external texture names manually and that solved the issue.

Here is a test pk3 for OpenArena to showcase the problem. The map name is shadertest1 https://drive.google.com/open?id=17SRdELSBu3oV-4Pj5yzAzFBoGk69Q7MA

There are a few variations of the shaders with some parameters commented out, the ones that fail are the only ones to use both q3map_lightmapSize and q3map_styleMarker. It must be compiled with the x64 version of q3map2 to compile the high resolution lightmaps or it may run out of memory. I used v2.5.17. It is included in the pk3 with a batch file.

Thanks

[TTimo]

Thank you, feel free to submit a patch or merge request for this.

[Garux]

#60 I'm sure there is TODO in the code, sorta make it work with lightstyles

[Fighter19]

EDIT3: Sorry for bumping, I think I misunderstood the problem.

But from my knowledge OpenArena does not support any lightmap or vertex styles. (As I understood OA uses "IBSP" format, while usually "RBSP" contains multiple lightmaps and styles).

[Garux]

q3map2 styles hack via generated shaders is implied