TTT2 icon indicating copy to clipboard operation
TTT2 copied to clipboard

Map Breaking Gamemode

Open TimGoll opened this issue 1 year ago • 4 comments

TTT2 v0.14.0

Aparantly this map breaks the whole gamemode: https://steamcommunity.com/sharedfiles/filedetails/?id=2991532471

Image

TimGoll avatar Nov 01 '24 19:11 TimGoll

Image The map has this file (b-draw_lib.lua) which seems to overwrite some draw functions that TTT2 uses.

NickCloudAT avatar Nov 02 '24 08:11 NickCloudAT

Hmm, good to know then. I'm not sure if there is a good way to fix that though. We could make our functions a bit more resilient so that they do not error out but use a default color or so

TimGoll avatar Nov 02 '24 13:11 TimGoll

Hmm, good to know then. I'm not sure if there is a good way to fix that though. We could make our functions a bit more resilient so that they do not error out but use a default color or so

Essentially this is a file conflict and solving this issue on any other level is nothing more than a band-aid

This breakage is unfortunate and probably unintentionally caused by fb43db1 and/or a3057d3

The changes made in those commits are not self-contained and we cannot simply move them to another file

If we want to solve this ourselves we would need to move every function that was remotely touched in the above commits into a new file/lib and ensure that those use another name and revert/remove the b-draw_lib.lua file

Given that our file doesn't really look like the original b-draw_lib.lua [1] anymore we might be fine with pushing the functions in that file into our draw extension (half of the functions are already namespaced to draw. anyway so we might as well)

[1] https://github.com/bull29/b_draw-lib/blob/master/lua/autorun/client/b-draw_lib.lua

Histalek avatar Nov 06 '24 17:11 Histalek

I support moving them to a new file. Renaming them is probably also fine as I don't think any addon (besides our killer info addon) uses these functions anyway

TimGoll avatar Nov 07 '24 11:11 TimGoll