TTT2 icon indicating copy to clipboard operation
TTT2 copied to clipboard

Hook: Added hook "TTT2PlayDeathScream" for deathscreams

Open NickCloudAT opened this issue 1 year ago • 2 comments

This hook allows to change the sound of the deathscream or cancel it outright.

Maybe I'm mistaken but I thought the table approach would be the most appropriate one here. Please correct me if not.

Changelog will follow when this is done.

NickCloudAT avatar Oct 16 '24 15:10 NickCloudAT

Woohoo, awesome to see this making it in!

  • Sc00by

Aeconomy7 avatar Oct 16 '24 17:10 Aeconomy7

(any feedback appreciated)

NickCloudAT avatar Oct 19 '24 18:10 NickCloudAT

Latest commit changed to how isSilent should be handled instead, as per suggestion.

NickCloudAT avatar Oct 24 '24 08:10 NickCloudAT

Anything else for this to get merged? Just so it does not stale :P

NickCloudAT avatar Jan 03 '25 09:01 NickCloudAT

Anything else for this to get merged? Just so it does not stale :P

image

TimGoll avatar Jan 03 '25 09:01 TimGoll

Anything else for this to get merged? Just so it does not stale :P

image

dangit, ofc I missed that. Should be resolved now.

NickCloudAT avatar Jan 03 '25 09:01 NickCloudAT

dangit, ofc I missed that. Should be resolved now.

Style is still complaining :D

TimGoll avatar Jan 03 '25 09:01 TimGoll

dangit, ofc I missed that. Should be resolved now.

Style is still complaining :D

I might just be retarded.. But I actually don't get why it's complaining o.O?

NickCloudAT avatar Jan 03 '25 09:01 NickCloudAT

Ok.. ffs.. Took me 10 years now to know how the freak this style check works.. Well, better now than never.

NickCloudAT avatar Jan 03 '25 09:01 NickCloudAT

Ok.. ffs.. Took me 10 years now to know how the freak this style check works.. Well, better now than never.

FYI, if you install stylua in VSCode it autodects the config file in the repo and does everything for you everytime you save the file

TimGoll avatar Jan 03 '25 09:01 TimGoll

Ok.. ffs.. Took me 10 years now to know how the freak this style check works.. Well, better now than never.

FYI, if you install stylua in VSCode it autodects the config file in the repo and does everything for you everytime you save the file

Ohhhhhhh wait actually? Damn, will do that rn.

NickCloudAT avatar Jan 03 '25 09:01 NickCloudAT

Ohhhhhhh wait actually? Damn, will do that rn.

Yes! I wasn't a fan of it initially, but Histalek was right, it is really nice. If you have any issues with it, ask him, he knows how to fix it :D

TimGoll avatar Jan 03 '25 09:01 TimGoll