Not working translations for karma changes

[mexikoedi]

Your version of TTT2 (mandatory)

Leave one of the following:

• Workshop version from Steam

Describe the bug (mandatory)

The prints in the server console for karma related changes are not being translated correctly. See below.

To reproduce

Steps to reproduce the behaviour:

1. Go into a round
2. Play a round
3. Reduce/Increase your karma
4. See described issue

Expected behaviour

It should use the translations instead.

Context (please provide as much as you can)

• Collection link of your Server: https://steamcommunity.com/sharedfiles/filedetails/?id=1822673195
• Example:

An amount of 6 was changed for the reason of karma_enemyhurt_tooltip
An amount of -152 was changed for the reason of karma_teamkill_tooltip
An amount of -101 was changed for the reason of karma_teamhurt_tooltip

[TimGoll]

The prints in the server console for karma related changes are not being translated correctly.

Are any prints to the server console translated? Afaik they are all in english

[TimGoll]

Or is your point that the sentence is weirdly worded?

[TimGoll]

Ah, oh, I see your point, lol. Thanks!

[EntranceJew]

the problem is that LANG translation features aren't shared by the server, and so even if we migrated these strings to the language files we'd have no means of displaying them

many such situations occur in several spots like: addons/TTT2/gamemodes/terrortown/gamemode/server/sv_admin.lua:54 or more broadly combed: addons/TTT2/gamemodes/terrortown/gamemode/server/sv_main.lua:336

i think the first step would be to make more parts of LANG shared, since we already have a concept of a "server language" via ttt_language

[TimGoll]

i think the first step would be to make more parts of LANG shared, since we already have a concept of a "server language" via ttt_language

This would be a solution, yes. But IMHO the console language should always be english, so no localization is needed. This also only seems a problem here for karma. Maybe it would be an easy to fix to add a readable name to the karma objects. I'd have to check the code