TTT2 icon indicating copy to clipboard operation
TTT2 copied to clipboard

MSTACK: Fix missing sound for notification cue

Open EntranceJew opened this issue 5 months ago • 12 comments

that noise was missing and i'm tired of seeing developer prints about noises that don't exist

EntranceJew avatar Feb 03 '24 21:02 EntranceJew

huh, interesting. Thanks for bringing this over. I'm wondering if we should also add a convar to disable this, but I guess we probably shouldn't as long as nobody is complaining.

I thought for a moment if we should also rename this sound like they did in TTT, but I don't think that it is likely to clash with anything really

TimGoll avatar Feb 03 '24 21:02 TimGoll

it is actually incredibly annoying, but this should motivate people to use less MSTACK prompts, or for us to innovate a recyclable MSTACK id to refresh it like a Toast Notification

EntranceJew avatar Feb 03 '24 23:02 EntranceJew

it is actually incredibly annoying

My fears as well, but this sentence made me chuckle

TimGoll avatar Feb 03 '24 23:02 TimGoll

Actually if it is that annoying, we should really consider either removing this sound cue entirely or we might also add the config convar. Even though i dislike convars, i feel this is nothing many people will enjoy.

saibotk avatar Feb 04 '24 01:02 saibotk

sounds complicated

EntranceJew avatar Feb 04 '24 01:02 EntranceJew

agreed on the sound being annoying. Just tested it. Maybe a different sound would be nice. Maybe the sound used in https://wiki.facepunch.com/gmod/chat.PlaySound

TimGoll avatar Feb 04 '24 11:02 TimGoll

agreed on the sound being annoying. Just tested it. Maybe a different sound would be nice. Maybe the sound used in https://wiki.facepunch.com/gmod/chat.PlaySound

wouldn't it be confusing for the player to potentially hear HudChat.Message while both chatting and getting MSTACK popups?

EntranceJew avatar Feb 04 '24 17:02 EntranceJew

agreed on the sound being annoying. Just tested it. Maybe a different sound would be nice. Maybe the sound used in https://wiki.facepunch.com/gmod/chat.PlaySound

wouldn't it be confusing for the player to potentially hear HudChat.Message while both chatting and getting MSTACK popups?

Probably right, yes. Then let's not do it then.

I've thought about it for a while and do we really want it then? Wouldn't it just be better to not add this annoying feature and remove the bug by removing the sound play that causes an error in the console?

TimGoll avatar Feb 04 '24 18:02 TimGoll

if this is blocking something it's gonna need some direction

EntranceJew avatar Feb 11 '24 11:02 EntranceJew

nah, it's not blocking. I jsut think we're not sure how to proceed with this. While we all agree it is good to keep feature parity to TTT, it is also kinda annoying

TimGoll avatar Feb 11 '24 11:02 TimGoll

attaching here so it doesn't get lost, i did an alternate "heavier" version of the "talk" sfx that is referenced earlier to further distinguish them from each-other talk2.zip

EntranceJew avatar Feb 11 '24 12:02 EntranceJew

I'd still favor it, if we could just remove this altogether.

saibotk avatar Feb 11 '24 15:02 saibotk

If it's about a vote, I also would vote against the sound and remove the bug.

ZenBre4ker avatar Feb 27 '24 19:02 ZenBre4ker

given that this hasn't existed/worked in the last 12 years or so i would also vote to remove this completely

Histalek avatar Mar 04 '24 11:03 Histalek

Closing in favor of #1460

TimGoll avatar Mar 06 '24 23:03 TimGoll