dgp icon indicating copy to clipboard operation
dgp copied to clipboard

Published 20 hours ago • verified publisher icon TRI-ML

schema: add KeyPoint3D, KeyLine3D, Polygon3D

Open pd-nisse opened this issue 3 years ago • 5 comments

While KeyPoint2D, KeyLine2D, Polygon2D allow for point/line geomtries on the image plane, we would like to store the the 3D equivalents in carthesian coordinates in sensor space.

This change is Reviewable

pd-nisse avatar Nov 02 '21 18:11 pd-nisse

@quincy-kh-chen : Thanks for the comments! I re-ordered per your draft, but surface_normals_2D inhibits the index 13 already. How would you like to see this resolved?

pd-nisse avatar Nov 05 '21 09:11 pd-nisse

@quincy-kh-chen : I left the order as appending and built the proto files.

pd-nisse avatar Nov 19 '21 10:11 pd-nisse

Hi @pd-nisse @quincy-kh-chen @yuta-tsuzuki-woven

I'm Akira from Woven Alpha. We are also interested in this PR and looking forward to getting this PR merged. All comments look resolved and let me ask what is remaining.

Thanks in advance.

akira-wakatsuki avatar Feb 02 '22 09:02 akira-wakatsuki

Will get this moving.

nehalmamgain avatar Apr 25 '22 03:04 nehalmamgain

Continuing discussion here

nehalmamgain avatar Aug 01 '22 04:08 nehalmamgain