please-cli icon indicating copy to clipboard operation
please-cli copied to clipboard

Add support for Ollama backend

Open Dadams2 opened this issue 1 year ago • 5 comments

These are the bare minimum changes. It might be reasonable to also include in the documentation:

  • basic setup instructions for ollama. Specifically running the following before using please:
ollama serve
  • instructions on a good default model to use with ollama e.g -m llama3.1

I think it is somewhat safe to assume that if a user knows they want ollama they will want to specify a model themselves. This assumption is why I have omitted setting more defaults.

Dadams2 avatar Aug 10 '24 10:08 Dadams2

Could you also please sign your commit?

thomas-endres-tng avatar Aug 10 '24 10:08 thomas-endres-tng

of course! please forgive the force push

Dadams2 avatar Aug 10 '24 11:08 Dadams2

@Dadams2 I know it’s been a while, but you’ll also need to sign off your commit. If you are still interested in getting this merged, you can easily achieve that by running

git rebase -i origin/main --signoff

The conflicts also need to be resolved, of course.

ghost91- avatar Feb 06 '25 23:02 ghost91-

@ghost91- Have done!

Dadams2 avatar Feb 19 '25 05:02 Dadams2

One question about that - you can already set the url manually. Why do we still need the ollama option?

thomas-endres-tng avatar Feb 19 '25 07:02 thomas-endres-tng