TNG
Proper support of angular 14+ (Not working in angular 16 due to absent ngcc)
Angular ngcc processing ngqp as view engine:
Processing legacy "View Engine" libraries:
- @ngqp/core [fesm2015/esm2015] (https://github.com/TNG/ngqp.git)
- @ngqp/core [esm2015/esm2015] (https://github.com/TNG/ngqp.git)
- @ngqp/core [main/umd] (https://github.com/TNG/ngqp.git)
What's your idea?
Save time for ngcc processing Describe the solution you'd like
Could you please update dependencies to 14 angular in package json and ng-packagr and after fix all stuff update your lib (yes it's breaking change). Because it should be compiled properly against ivy, and also check parameter compilationMode: 'partial' for publishing.
Additional context
I definitely wouldn't mind this. Are you interested in submitting a PR? I probably won't have time to do this myself, but happy to support.
@Airblader ok, I will prepare PR soon, but can't test it before release, I just check for build properly, and after you release, I can test it
@Airblader I stuck in your demo app, while trying to update project to 14 angular due to using raw-loader.
Webpack 5 don't have that loader, and have own 'asset/source' type for that. Currently it possible only via custom webpack config. Details: https://github.com/angular/angular-cli/pull/21305
Can I only prepare PR with library change without changing demo website?
Yes, I'm aware of that issue, which is why I never updated the demo either. I'm OK with excluding the demo here, but we'll need some kind of verification that it does work.
It's hard to get, due to demo project contains 'raw-loader' webpack plugin, but angular 14 use webpack 5 where raw-loader does not exist, and need to change strategy of loading .ts files as text.
looks like angular 16 remove ngcc util and library does not work more.
This likely means that the library (@ngqp/core) which declares QueryParamModule is not compatible with Angular Ivy.
Check if a newer version of the library is available, and update if so. Also consider checking with the library's authors to
see if the library is expected to be compatible with Ivy.
commit: https://github.com/TNG/ngqp/commit/979f038c02f455bbdd6fab7d87561f6c2d77c652