JGiven icon indicating copy to clipboard operation
JGiven copied to clipboard

provide JGivenStage outside of spring context - for kotlin allopen

Open jangalinski opened this issue 5 years ago • 2 comments

When using kotlin, all stage classes and functions have to declared open to get JGiven working.

The kotlin compiler plugin "all-open" can do this for you, which is very convenient. But it requires an annotation on class level to work.

The JGivenStage annotation used in jgiven-spring is a solution for this, but what if you do not use spring?

I ended up defining a custom JGivenStage annotation twice in my kotlin projects, so I would like to have a "centralized" solution.

Maybe introducing a jgiven-kotlin module could be a good place for this?

Would you be open for a PR?

jangalinski avatar Apr 25 '19 10:04 jangalinski

I am always open for PR :-). The question is whether a whole jgiven-kotlin module is not a bit of an overkill for just a single annotation. How would such an annotation have to look like?

janschaefer avatar May 01 '19 11:05 janschaefer

see #407

jangalinski avatar May 10 '19 10:05 jangalinski