ArchUnit icon indicating copy to clipboard operation
ArchUnit copied to clipboard

#641 Added tooling tests

Open crizzis opened this issue 2 years ago • 1 comments

crizzis avatar Jun 10 '22 10:06 crizzis

Hey, thanks for all the hard work, but can you please put in a detailed description of why (I just see no description provided)? My problem here is: This adds 2.5K lines of code that we will have to maintain in the future. And I don't exactly see the benefit yet. In particular, what would be important to me is to weigh this against the simple system property filter suggested in the issue and then give detailed reasons why not to go the simple way. Because I think we could add a simple filtering based on system properties that would solve the issue creators problem with a couple of hundred LOC for prod and test code altogether. And it would work with any tool, be it Gradle, Maven or IntelliJ, because system properties can always be supplied. So if we would go this way here, where we need this massive complexity of test infrastructure, then we need to state a good reason for it IMHO. So can you outline this? What is your vision? Why do we need these tooling tests for it? What would we gain over the simple filtering mechanism?

codecholeric avatar Jun 12 '22 09:06 codecholeric

I implemented a simplified version in #1280. Since I have no capacity to work on this further, I'm gonna close this. Feel free to reopen if you want to pick this up or add further improvements.

codecholeric avatar Apr 10 '24 22:04 codecholeric