BalanduinoAndroidApp icon indicating copy to clipboard operation
BalanduinoAndroidApp copied to clipboard

Published 20 hours ago • verified publisher icon TKJElectronics

squid:S1066 - Collapsible if statements should be merged

Open m-ezzat opened this issue 9 years ago • 3 comments

This pull request is focused on resolving occurrences of Sonar rule squid:S1066 - Collapsible "if" statements should be merged

You can find more information about the issue here: https://dev.eclipse.org/sonar/coding_rules#q=squid:S1066

Please let me know if you have any questions.

M-Ezzat

m-ezzat avatar May 27 '16 14:05 m-ezzat

@m-ezzat please see my inline comments. This PR actually does not compile: https://travis-ci.org/TKJElectronics/BalanduinoAndroidApp/builds/133403762. Is there any particular reason why you want to do all this?

Lauszus avatar May 27 '16 17:05 Lauszus

@Lauszus, I updated the PR, the reason is to fix the current code quality issues, as we agreed me & Mr.Thomas Kølbæk. Thanks for your notices!

m-ezzat avatar May 27 '16 18:05 m-ezzat

I am not sure whether you do not agree with these changes or not. Please close this PR if not.

m-ezzat avatar Jun 28 '16 04:06 m-ezzat