Tommy McNeely

Results 134 comments of Tommy McNeely

What is the status of this? Do I need to do anything else (besides bumping the versions?)

If it becomes "too hairy" you can always have a "module version vs elasticsearch version" supported matrix, so you would know if you need to run ES 5.2 or earlier...

The timeout for the init script is just "kicking off" elasticsearch, but from the time the init script comes back (which is actually really fast), to the time when elasticsearch...

Perhaps, I agree. The module should follow the default by default. Maybe debug is the default? either way I think it should be exposed as a parameter.

Yes, it is quite easy, probably 2-3 lines of code, but seeing as how this module has over 20 PRs that have not seen much attention from "elastic" ... I...

Having the helm chart version match the app version *rarely* works because helm chart versions do not support the "x.y.z-R" type releases like RPMs... so many apps have diverged that...

Hmm, there is usually some "job" (gh-action, gitlab-ci, etc) that combines all the commit messages to a CHANGELOG.md during a release, but those are usually less useful than when someone...

I am thinking a directory of markdown docs, sort of like above, provide a fairly simple way of sprinkling documentation and code together into a single file. I might add...

@rayson1223 - I will admit that I am the "IT" guy, and I was just part of the project to help with the SAML stuff. I know "it works" for...

my session does not have .Session()? I assume that is what you meant by "s" ? Maybe? ``` r.GET("/", func(c *gin.Context) { session := sessions.Default(c) // the rest ``` ......