check for 'undefined' in mapping and condition expressions

[ecarlier-tibco]

I'm submitting a ... (check one with "x")

[] bug report => search github for a similar issue or PR before submitting
[x] feature request
[] support request
[] general question

Expected behavior: In Object structure, some attributes may not be present and mapping or condition logic may defer depending on the presence or not of those attributes. This goes in pair with ability to have if ... then ... else statement in conditions and mapping expressions

What is the motivation / use case for changing the behavior? Some application require this especially as soon as you have payloads with optional parameters.

[lixingwang]

@ecarlier-tibco We already have this feature implemented. to check if the field undefine or empty please use $xxxx.attribute == nil. try ternary expression if you want if .. then.

Such as: $activity[rest2].body.field1 != nil ? "field1 not empty " : "field1 empty"

[mellistibco]

@ecarlier-tibco did this work for you?

[ecarlier-tibco]

sorry had not the time to test it yet will do asap

Eric

On Wed, Jun 27, 2018 at 4:13 PM, Matt Ellis [email protected] wrote:

@ecarlier-tibco https://github.com/ecarlier-tibco did this work for you?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/TIBCOSoftware/flogo/issues/295#issuecomment-400686632, or mute the thread https://github.com/notifications/unsubscribe-auth/ASzNY0mH1XZ_EWhGTOC8lLLTCRGZCknlks5uA5MGgaJpZM4UkaMS .

--

Eric Carlier, Office of the CTO, EMEA M : +33 6 10 81 44 02 O : +33 1 44 51 78 87 E : [email protected] TIBCO Software, 25 rue Balzac, 75008 Paris, FRANCE

http://goog_685059704 [image: TIBCO NOW] http://now.tibco.com/

[ecarlier-tibco]

it seems to work except that the web ui does not accept this syntax but works in cli

Cheers Eric

On Wed, Jun 27, 2018 at 4:20 PM, Eric Carlier [email protected] wrote:

sorry had not the time to test it yet will do asap

Eric

On Wed, Jun 27, 2018 at 4:13 PM, Matt Ellis [email protected] wrote:

@ecarlier-tibco https://github.com/ecarlier-tibco did this work for you?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/TIBCOSoftware/flogo/issues/295#issuecomment-400686632, or mute the thread https://github.com/notifications/unsubscribe-auth/ASzNY0mH1XZ_EWhGTOC8lLLTCRGZCknlks5uA5MGgaJpZM4UkaMS .

--

Eric Carlier, Office of the CTO, EMEA M : +33 6 10 81 44 02 O : +33 1 44 51 78 87 E : [email protected] TIBCO Software, 25 rue Balzac, 75008 Paris, FRANCE

http://goog_685059704 [image: TIBCO NOW] http://now.tibco.com/

--

Eric Carlier, Office of the CTO, EMEA M : +33 6 10 81 44 02 O : +33 1 44 51 78 87 E : [email protected] TIBCO Software, 25 rue Balzac, 75008 Paris, FRANCE

http://goog_685059704 [image: TIBCO NOW] http://now.tibco.com/

[mellistibco]

cool, thanks. @fcastill can you take a look at the webui part?

[ecarlier-tibco]

but it seems to only work with string. I tried with an array parameter, and also a number parameter, and I could not get it to work

Eric

On Wed, Jun 27, 2018 at 4:44 PM, Eric Carlier [email protected] wrote:

it seems to work except that the web ui does not accept this syntax but works in cli

Cheers Eric

On Wed, Jun 27, 2018 at 4:20 PM, Eric Carlier [email protected] wrote:

sorry had not the time to test it yet will do asap

Eric

On Wed, Jun 27, 2018 at 4:13 PM, Matt Ellis [email protected] wrote:

@ecarlier-tibco https://github.com/ecarlier-tibco did this work for you?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/TIBCOSoftware/flogo/issues/295#issuecomment-400686632, or mute the thread https://github.com/notifications/unsubscribe-auth/ASzNY0mH1XZ_EWhGTOC8lLLTCRGZCknlks5uA5MGgaJpZM4UkaMS .

--

Eric Carlier, Office of the CTO, EMEA M : +33 6 10 81 44 02 O : +33 1 44 51 78 87 E : [email protected] TIBCO Software, 25 rue Balzac, 75008 Paris, FRANCE

http://goog_685059704 [image: TIBCO NOW] http://now.tibco.com/

--

Eric Carlier, Office of the CTO, EMEA M : +33 6 10 81 44 02 O : +33 1 44 51 78 87 E : [email protected] TIBCO Software, 25 rue Balzac, 75008 Paris, FRANCE

http://goog_685059704 [image: TIBCO NOW] http://now.tibco.com/

--

Eric Carlier, Office of the CTO, EMEA M : +33 6 10 81 44 02 O : +33 1 44 51 78 87 E : [email protected] TIBCO Software, 25 rue Balzac, 75008 Paris, FRANCE

http://goog_685059704 [image: TIBCO NOW] http://now.tibco.com/

[lixingwang]

@ecarlier-tibco Can you share your flogo.json with number and array?

[ecarlier-tibco]

Here it is flogo.json.zip

[lixingwang]

@ecarlier-tibco

1. For your array expression which is invalid. ["ddd"] not an valid literal. please correct to $.content.ParamArray2 != nil ? $.content.ParamArray2 : "[EMPTY]" or remove []
2. For number: so far we are not support literal negtive number in expression. Could you please create GH issue?

For #2, you can change -1 to 0 ~ MAX to unblock you

[ecarlier-tibco]

@lixingwang

1. I tried both options you mentioned. It works ok if I pass an array param in my test request body. But I don't, and then get into the "EMPTY" case, then the subsequent loop for logging fails (likely as it does not recognize an array ?)
2. Created https://github.com/TIBCOSoftware/flogo/issues/301

[lixingwang]

@ecarlier-tibco Yes, for iterator, the iterate must be a number or array, it cannot iterate over a string, like "empty". It is expected behavior.

[ecarlier-tibco]

Yes but my point is that my application is expecting an array. If it is not provided by the input request, I want to set an empty array, or an array with a specific value, by default, so that my app does not fail because the array is not there

Le 28 juin 2018 à 17:51, Tracy Li [email protected] a écrit :

@ecarlier-tibco Yes, for iterator, the iterate must be a number or array, it cannot iterate over a string, like "empty". It is expected behavior.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[lixingwang]

@ecarlier-tibco Got you. but now you are using expression $.content.ParamArray2 != nil ? $.content.ParamArray2 : "EMPTY" it will return string "EMPTY" while $.content.ParamArray2 undefine.

we cannot have a default value because the value comes from your mapping.

You can try with this expression: $.content.ParamArray2 != nil ? $.content.ParamArray2 : "[]".

[ecarlier-tibco]

Ok the empty array works fine : $.content.ParamArray2 != nil ? $.content.ParamArray2 : "[]" But the one you mentioned initially, setting a default array with at least one element, does not work : $.content.ParamArray2 != nil ? $.content.ParamArray2 : "[EMPTY]"

Thanks

[lixingwang]

@ecarlier-tibco Yes. we do not support that. in the future we will provide an array function which allows the user to create an array, such as $.content.ParamArray2 != nil ? $.content.ParamArray2 : array.create("empty")