Tilman Hausherr

Results 65 comments of Tilman Hausherr

I suspect these tags must be 4 bytes long. CFFParser.readTagName() reads 4 bytes.

Thanks, I committed the last one, but differently.

I'm done for now. Thanks again. More later or tomorrow.

The one in TrueTypeCollection.java I don't agree. It looks kind of weird that two parser objects are generated but only one is used.

The one about the double-checked-locking I'll do after the next release. This is a very sensitive topic.

Thanks, I did several of them. I created two issues for the DeviceN stuff (PDFBOX-5121 and PDFBOX-5122) because of the amazing speed improvement. Please merge again, so that I can...

The change in getDiskCacheFile() I don't want to do, inline assignments are considered messy. (Please don't fix any that we may have 😂)

You are not forgotten, but I've been busy. Might take a few days.

This is a read only mirror. Please close this and open an issue in JIRA. https://issues.apache.org/jira/browse/PDFBOX

Of course every speed increase is welcome, but this change is one to be discussed with "the rest of the gang" - what is if one of the `processOperator` methods...