GRAND-plus icon indicating copy to clipboard operation
GRAND-plus copied to clipboard

Suggest to loosen the dependency on requests

Open Agnes-U opened this issue 1 year ago • 0 comments

Hi, your project GRAND-plus(commit id: 5b960cfec8c5e4658d86e381241b43268b1d679b) requires "requests==2.24.0" in its dependency. After analyzing the source code, we found that the following versions of requests can also be suitable, i.e., requests 2.22.0, 2.23.0, since all functions that you directly (2 APIs: requests.sessions.Session.init, requests.exceptions.ConnectionError.init) or indirectly (propagate to 13 requests's internal APIs and 5 outsider APIs) used from the package have not been changed in these versions, thus not affecting your usage.

Therefore, we believe that it is quite safe to loose your dependency on requests from "requests==2.24.0" to "requests>=2.22.0,<=2.24.0". This will improve the applicability of GRAND-plus and reduce the possibility of any further dependency conflict with other projects.

May I pull a request to further loosen the dependency on requests?

By the way, could you please tell us whether such an automatic tool for dependency analysis may be potentially helpful for maintaining dependencies easier during your development?

Agnes-U avatar Nov 06 '22 14:11 Agnes-U