Thore Sommer

Results 112 comments of Thore Sommer

> Maybe use black to unify the code format? Good idea. I did a test run and it touches basically 1/3 of the code base. We will probably have to...

> If we're not backporting patches and have a small PR queue we could just run it over the whole code base... Yeah you are right. I only backported very...

@ansasaki my idea was to do simplifications where possible. We had a mix of keys were only in some cases the encryption was supported. In my opinion there is no...

> I understand your way of thinking, but keeping the support for password encrypted keys allows the user who wants to use an existing encrypted key. Some may see the...

> It's only really useful if someone has existing certs and can't generate new ones, right? Yeah pretty much, we also agreed that for automigration we only support the basic...

@ansasaki if the password discussion is delaying some of your work then we just keep it in for now and the deprecate it later.

I really like the idea. There are a few things to consider: - The Python code currently relies on ConfigParser and that the logging config is in that INI format....

@ueno can you open a enhancement proposal for this change?

We have chosen not switch to TOML for the Python components. The rest is implemented in #1068.

Yes the naming should be consistent. The verifier API uses `metadata` and internally for the agent in the database `meta_data` is used. Changing the names would break the verifier or...