PILOS icon indicating copy to clipboard operation
PILOS copied to clipboard

UX: Add tooltip to room details button

Open samuelwei opened this issue 1 month ago • 3 comments

Type

  • Bugfix
  • Feature
  • Documentation
  • Refactoring (e.g. Style updates, Test implementation, etc.): UX
  • Other (please describe):

Checklist

  • [ ] Code updated to current develop branch head
  • [ ] Passes CI checks
  • [ ] Is a part of an issue
  • [ ] Tests added for the bugfix or newly implemented feature, describe below why if not
  • [ ] Changelog is updated
  • [ ] Documentation of code and features exists

Changes

  • Added tooltip to room details button
  • Added aria-label to room details button

Other information

Motivation: To improve learnability, all icon-only buttons should have a tooltip explaining the button's action.

Before image

After image

samuelwei avatar Oct 31 '25 09:10 samuelwei

[!IMPORTANT]

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • [ ] Create PR with unit tests
  • [ ] Post copyable unit tests in a comment
  • [ ] Commit unit tests in branch ux-add-room-info-tooltip

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot] avatar Oct 31 '25 09:10 coderabbitai[bot]

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 96.74%. Comparing base (b41368d) to head (e7a6001). :warning: Report is 23 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2576      +/-   ##
=============================================
- Coverage      96.75%   96.74%   -0.01%     
- Complexity      1812     1816       +4     
=============================================
  Files            433      434       +1     
  Lines          12471    12483      +12     
  Branches        2078     2078              
=============================================
+ Hits           12066    12077      +11     
- Misses           405      406       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Oct 31 '25 09:10 codecov[bot]

PILOS    Run #2687

Run Properties:  status check failed Failed #2687  •  git commit e7a60014c2: UX: Add tooltip to room details button
Project PILOS
Branch Review ux-add-room-info-tooltip
Run status status check failed Failed #2687
Run duration 07m 31s
Commit git commit e7a60014c2: UX: Add tooltip to room details button
Committer Samuel Weirich
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 607
View all changes introduced in this branch ↗︎

Tests for review

Failed  e2e/RoomsJoinWithLobby.cy.js • 1 failed test • System tests

View Output

Test Artifacts
Room Join with lobby settings > Lobby enabled for guests only Test Replay Screenshots

cypress[bot] avatar Oct 31 '25 09:10 cypress[bot]