PILOS icon indicating copy to clipboard operation
PILOS copied to clipboard

UX: Add more buttons to copy only link or access code

Open samuelwei opened this issue 5 months ago • 3 comments

Fixes #1419

Type

  • Bugfix
  • Feature
  • Documentation
  • Refactoring (e.g. Style updates, Test implementation, etc.) UX
  • Other (please describe):

Checklist

  • [ ] Code updated to current develop branch head
  • [ ] Passes CI checks
  • [ ] Is a part of an issue
  • [ ] Tests added for the bugfix or newly implemented feature, describe below why if not
  • [ ] Changelog is updated
  • [ ] Documentation of code and features exists

Changes

  • Rename "Copy" button in room share dialog to "Copy invitation message"
  • Add two buttons to room share dialog to only copy link and access code

Other information

image

First any easy fix for #1419, long term goal is to refactor access token handling, so the link can contain the access code

samuelwei avatar Jul 23 '25 14:07 samuelwei

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 93.68%. Comparing base (085a2eb) to head (5720c1d).

Files with missing lines Patch % Lines
resources/js/components/RoomShareButton.vue 0.00% 8 Missing :warning:
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2325      +/-   ##
=============================================
- Coverage      96.71%   93.68%   -3.03%     
  Complexity      1642     1642              
=============================================
  Files            425      425              
  Lines          11950    11956       +6     
  Branches        2063     2063              
=============================================
- Hits           11557    11201     -356     
- Misses           393      755     +362     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Jul 23 '25 14:07 codecov[bot]

[!IMPORTANT]

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Jul 23 '25 14:07 coderabbitai[bot]

PILOS    Run #2565

Run Properties:  status check failed Failed #2565  •  git commit 5720c1ddb0: UX: Add more buttons to copy only link or access code
Project PILOS
Branch Review 1419-simple-solution-to-only-copy-room-link-when-clicking-on-copy-in-share-menu
Run status status check failed Failed #2565
Run duration 07m 43s
Commit git commit 5720c1ddb0: UX: Add more buttons to copy only link or access code
Committer Samuel Weirich
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 597
View all changes introduced in this branch ↗︎

Tests for review

Failed  tests/Frontend/e2e/RoomsViewGeneral.cy.js • 1 failed test • Frontend tests

View Output

Test Artifacts
Room View general > room view as moderator Test Replay Screenshots

cypress[bot] avatar Jul 23 '25 14:07 cypress[bot]