PILOS Refactor links

Type

Bugfix
Feature
Documentation
Refactoring (e.g. Style updates, Test implementation, etc.) Refactor
Other (please describe):

Checklist

[x] Code updated to current develop branch head
[x] Passes CI checks
[ ] Is a part of an issue
[ ] Tests added for the bugfix or newly implemented feature, describe below why if not
[ ] Changelog is updated
[ ] Documentation of code and features exists

Changes

Refactor nested button links in App-Banner and Meetings List

Summary by CodeRabbit

Based on the comprehensive summary, here are the updated release notes:

New Features
- Added disabled prop to various delete and action buttons across admin settings components.
- Introduced event emissions for busy states in user-related components.
Improvements
- Enhanced button behavior to prevent interactions during busy states.
- Refined button rendering logic in admin views to improve user experience.
Bug Fixes
- Corrected button interaction during asynchronous operations.
- Fixed potential navigation issues during loading states.
UI/UX Changes
- Modified button rendering to provide clearer feedback during processing.
- Improved control flow for admin interface buttons.

Jan 23 '25 11:01 samuelwei

Walkthrough

The pull request encompasses a series of consistent updates across multiple Vue components and views. The changes primarily focus on enhancing button behavior during busy states, introducing a new disabled prop to various delete and action buttons. Components now dynamically control button rendering and interaction based on the isBusy state, preventing navigation and interactions during loading. Additionally, there are modifications to component rendering, such as replacing <router-link> with <Button> components and adjusting link and button styles in components like AppBanner.vue. The changelog reflects these changes, documenting new features, improvements, and bug fixes.

Changes

File	Change Summary
`resources/js/components/AppBanner.vue`	Restructured link rendering using `<Button>` with new computed properties `buttonClass` and `buttonStyle`
`resources/js/views/MeetingsIndex.vue`	Replaced `<router-link>` with `<Button>` for action navigation
`CHANGELOG.md`	Added entries for permission restrictions, environment variables, visual tests, and various fixes
`resources/js/components/RoomTabRecordingsDownloadButton.vue`	Updated button rendering based on `disabled` prop and modified `downloadUrl` logic
`resources/js/components/SettingsRolesDeleteButton.vue` `resources/js/components/SettingsRoomTypesDeleteButton.vue` `resources/js/components/SettingsServerPoolsDeleteButton.vue` `resources/js/components/SettingsServersDeleteButton.vue` `resources/js/components/SettingsUsersDeleteButton.vue`	Added `disabled` prop to control button state
`resources/js/views/AdminRolesIndex.vue` `resources/js/views/AdminRolesView.vue` `resources/js/views/AdminRoomTypesIndex.vue` `resources/js/views/AdminRoomTypesView.vue` `resources/js/views/AdminServerPoolsIndex.vue` `resources/js/views/AdminServerPoolsView.vue` `resources/js/views/AdminServersIndex.vue` `resources/js/views/AdminServersView.vue` `resources/js/views/AdminUsersIndex.vue` `resources/js/views/AdminUsersView.vue`	Updated button `as` attribute to conditionally render based on `isBusy` state, added `:disabled` bindings
`resources/js/components/UserTabEmail.vue` `resources/js/components/UserTabOtherSettings.vue` `resources/js/components/UserTabProfile.vue` `resources/js/components/UserTabSecurity.vue` `resources/js/components/UserTabSecurityPasswordSection.vue` `resources/js/components/UserTabSecurityRolesAndPermissionsSection.vue` `resources/js/components/UserTabSecuritySessionsSection.vue`	Introduced `busy` event and updated logic for managing loading states

Sequence Diagram

sequenceDiagram
    participant User
    participant Button
    participant Component
    
    User->>Button: Interact
    alt Is Busy
        Button->>Component: Check isBusy state
        Component-->>Button: isBusy = true
        Button->>Button: Disable/Change Rendering
        Button-->>User: Prevent Interaction
    else Not Busy
        Button->>Component: Perform Action
        Component->>Component: Execute Operation
    end

This sequence diagram illustrates the new button interaction pattern where the isBusy state controls the button's behavior, preventing user interactions during loading states.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

Jan 23 '25 11:01 coderabbitai[bot]

Codecov Report

Attention: Patch coverage is 38.63636% with 27 lines in your changes missing coverage. Please review.

Project coverage is 77.60%. Comparing base (d38c8ff) to head (0651cb8).

Files with missing lines	Patch %	Lines
...s/js/components/UserTabSecuritySessionsSection.vue	0.00%	10 Missing :warning:
resources/js/components/AppBanner.vue	0.00%	5 Missing :warning:
resources/js/components/UserTabSecurity.vue	0.00%	4 Missing :warning:
...s/js/components/UserTabSecurityPasswordSection.vue	0.00%	3 Missing :warning:
...ents/UserTabSecurityRolesAndPermissionsSection.vue	0.00%	3 Missing :warning:
resources/js/views/AdminUsersView.vue	0.00%	2 Missing :warning:

Additional details and impacted files

@@              Coverage Diff              @@
##             develop    #1811      +/-   ##
=============================================
- Coverage      81.47%   77.60%   -3.87%     
  Complexity      1410     1410              
=============================================
  Files            364      365       +1     
  Lines           9554     9582      +28     
  Branches         870      871       +1     
=============================================
- Hits            7784     7436     -348     
- Misses          1770     2146     +376

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Jan 23 '25 12:01 codecov[bot]

PILOS Run #1776

Run Properties: Failed #1776 • 0651cb88c9: Refactor links

Project	`PILOS`
Branch Review	`refactor-links`
Run status	`Failed #1776`
Run duration	`08m 49s`
Commit	`0651cb88c9: Refactor links`
Committer	`Samuel Weirich`
View all properties for this run ↗︎