Fix delete room member dialog not closed on 410 error
Fixes #1289
Type (Highlight the corresponding type)
- Bugfix
- Feature
- Documentation
- Refactoring (e.g. Style updates, Test implementation, etc.)
- Other (please describe):
Checklist
- [ ] Code updated to current develop branch head
- [ ] Passes CI checks
- [x] Is a part of an issue
- [ ] Tests added for the bugfix or newly implemented feature, describe below why if not
- [ ] Changelog is updated
- [ ] Documentation of code and features exists
Changes
- fix delete room member dialog not closed on 410 error
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 95.51%. Comparing base (
4185010) to head (968e99d). Report is 38 commits behind head on develop.
Additional details and impacted files
@@ Coverage Diff @@
## develop #1290 +/- ##
=============================================
+ Coverage 95.49% 95.51% +0.02%
Complexity 1305 1305
=============================================
Files 202 202
Lines 4530 4530
=============================================
+ Hits 4326 4327 +1
+ Misses 204 203 -1
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
PILOS
Run #446
Run Properties:
Passed #446 •
3445e4781f: Fix error handling for 410 errors (delete/edit members) (#1290)
| Project |
PILOS
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 03m 00s |
| Commit |
|
| Committer | Sabrina Wüst |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
46
|
| View all changes introduced in this branch ↗︎ | |
I would only remove the return, therefore the error message is shown and the modal is closed
In the RoomTabMembersEditButton the reaction to a 410 error seems to be the same to the code I suggested for the RoomTabMembersDeleteButton.
Maybe the code should also be changed there so that the error handling is similar.
I would only remove the return, therefore the error message is shown and the modal is closed
In the RoomTabMembersEditButton the reaction to a 410 error seems to be the same to the code I suggested for the RoomTabMembersDeleteButton.
Maybe the code should also be changed there so that the error handling is similar.
Agree, could you please include this change in this PR