teammates icon indicating copy to clipboard operation
teammates copied to clipboard

[#13304] Refactoring for Unit Test Access Controls

Open Ederich013 opened this issue 2 months ago • 3 comments

Part of #13304

Refactored test cases GetUsageStatisticsActionTest.java to PublishFeedbackSessionActionTest.java (71-78) and StudentCourseJoinEmailWorkerActionTest.java(94).

Details recorded here: Refactoring_Report.md

Ederich013 avatar Oct 22 '25 02:10 Ederich013

Hi, @InfinityTwo could you kindly review this pr? I checked previous pr #13359 and it seems the E2E test error isn't relevant with refactoring.

Ederich013 avatar Oct 24 '25 08:10 Ederich013

@Ederich013 Thanks for your contribution. However, the error was indeed caused by a refactoring, not by the one you mentioned, but another PR that has been merged (#13357)

At the moment, even if I were to review your PR, I can't merge it since it will still failing checks. However, I'll keep your PR in mind and review it onces the other refactor backlogs have been merged successfully in case of any cascading errors from other merges.

InfinityTwo avatar Oct 24 '25 15:10 InfinityTwo

@Ederich013 Alternatively, you can consider creating a fix based on your report that you made with another PR on the failing checks. If you can successfully fix the issue, I can review it and merge all your PRs

InfinityTwo avatar Oct 24 '25 15:10 InfinityTwo