[#13324] Migrate to InstructorFeedbackResultsPageSql
Part of #13324
Description
This PR introduces a SQL-based variant of the InstructorFeedbackResultsPage page object InstructorFeedbackResultsPageSqlas part of the ongoing data migration effort tracked in issue #13324. The goal is to ensure that all end-to-end (E2E) tests are fully compatible with the SQL storage backend.
Changes
-
Added
InstructorFeedbackResultsPageSql, a new E2E page object mirroring the existingInstructorFeedbackResultsPage, but backed by SQL entities such as:FeedbackSessionFeedbackQuestionFeedbackResponseFeedbackResponseCommentInstructorStudent
-
Replaced all references to legacy
*Attributestypes with SQL model classes. -
Refactored logic for:
- Fetching and displaying team names, section names, and user identities via SQL models.
- Handling missing responses using
FeedbackMissingResponsefiltering. - Constructing view-based table representations (question-centric, giver-recipient groupings, etc.).
- Rendering comments and statistics where applicable.
Tests
-
Introduced
InstructorFeedbackResultsPageE2ETest, a dedicated SQL-mode E2E test that:- Validates correct rendering of session details.
- Confirms proper behavior for questions with no responses.
-
Added a new SQL test data bundle:
InstructorFeedbackResultsPageE2ETestSql.json. -
Registered the test in
e2e-tests-sql.xml, maintaining alphabetical order.
Test Data Notes
-
The SQL data bundle sets up:
- 1 instructor
- 1 course
- 1 section and team
- 1 student
- 1 open feedback session with a single text question
- No feedback responses (to test the no-response view logic)
Hi @DhiraPT here's the migration PR for InstructorFeedbackResultsPageSql! Apologies for the long wait, was juggling a few other commitments in parallel. Let me know if any changes are needed!