teammates icon indicating copy to clipboard operation
teammates copied to clipboard

[#12552] Session Copy Modal: Instructors able to select the Course that they are copying from

Open Respirayson opened this issue 1 year ago • 8 comments

Fixes #12552

Outline of Solution To fix this issue, whenever the instructor selects the same course that the feedback session belongs to, there'll be an alert that pops up to say that there already exists a session with the same name in that course.

https://github.com/user-attachments/assets/8ec32680-4c65-42c0-9541-8c9fe91b4861

image

image

Respirayson avatar Jul 19 '24 18:07 Respirayson

I think standardizing the copies to have 'Copy of' prepended by default is okay, since the instructor would be able to edit this name in the modal, but @damithc would you like to weigh in on this change?

domoberzin avatar Jul 28 '24 03:07 domoberzin

@damithc Prof any updates?

mingyuanc avatar Jul 30 '24 16:07 mingyuanc

Hmm... Google docs allows the user to change the session name later, but we don't allow users to change the session name later. So, this strategy can lead to more severe problems than the current issue which is a mere inconvenience. For example, the user might not realize the name was prepended with a 'Copy of' until much later, when it is too late to even delete it. So, I prefer to keep the same session name unless the user changes it but prompt the user to change it when we detect a likely name collision e.g., if the name and course is same as the original, show a red warning message somewhere in the copy dialog. Is that feasible?

damithc avatar Jul 30 '24 16:07 damithc

@damithc thanks for the input Prof, I think that's a fair approach to take for this

@Respirayson could you implement it as described above? So there shouldn't be a 'Copy of' prepended but rather a warning/error within the popup when the name and course are the same

domoberzin avatar Jul 31 '24 00:07 domoberzin

Folks, This PR seems to be stalling (no activities for the past 8 days). :snail: :cry: Hope someone can get it to move forward again soon...

nusoss-bot avatar Aug 19 '24 14:08 nusoss-bot

Folks, This PR seems to be stalling (no activities for the past 7 days). :snail: :cry: Hope someone can get it to move forward again soon...

nusoss-bot avatar Aug 26 '24 15:08 nusoss-bot

Folks, This PR seems to be stalling (no activities for the past 13 days). :snail: :cry: Hope someone can get it to move forward again soon...

nusoss-bot avatar Sep 02 '24 03:09 nusoss-bot

Hi @Respirayson Could you fix the failing tests before we proceed with reviewing your PR? Thanks!

jasonqiu212 avatar May 30 '25 01:05 jasonqiu212