teammates icon indicating copy to clipboard operation
teammates copied to clipboard

[#13144] Copy students from existing students table to new students table

Open NeoHW opened this issue 1 year ago • 2 comments

Fixes #13144

Outline of Solution

Motivation and Context

For instructors who want to batch edit many students, they would have to copy and paste the whole sheet from existing students manually. The slightly clunky cell selection in the sheet would make it sometimes hard to select all students, especially if there are many students. Therefore, I would suggest the addition of a button to auto-import existing students into the new students sheet below. This would be a QOL change and also helps when instructors want to mass-edit students.

Changes

Frontend:

  1. Added a copy students button on the enrol page and formatted it.

Backend:

  1. Created functionality to copy existing students' spreadsheets into new students' spreadsheet
  • Ran into the issue that Existing students' spreadsheet has to be expanded for logic to work
  • Another issue was the asynchronous nature of fetching data with API calls in toggleExistingStudentsPanel
  1. Modify toggleExistingStudentsPanel to take in an optional callback
  • This ensures that the data is only copied after it has been successfully loaded

Video Demo

Before:

https://github.com/user-attachments/assets/a5cbb0d2-bd77-4b21-b254-388f52fad915

After:

https://github.com/user-attachments/assets/e3b2a84c-10e3-4992-94c8-7a99269f92dc

NeoHW avatar Jul 15 '24 19:07 NeoHW

Hi @NeoHW, thank you for your interest in contributing to TEAMMATES! However, your PR does not appear to follow our contribution guidelines:

  • Title must start with the issue number the PR is fixing in square brackets, e.g. [#<issue-number>]

Please address the above before we proceed to review your PR.

github-actions[bot] avatar Jul 15 '24 19:07 github-actions[bot]

Folks, This PR seems to be stalling (no activities for the past 7 days). :snail: :cry: Hope someone can get it to move forward again soon...

nusoss-bot avatar Jul 23 '24 14:07 nusoss-bot

PR put on hold, until the ongoing discussion in #13144 is resolved.

jasonqiu212 avatar May 26 '25 12:05 jasonqiu212

Closed, as per discussed in #13144

@NeoHW Thanks for this quick PR! I do apologize for this very late decision on the issue, hope you can understand 🙏

jasonqiu212 avatar May 27 '25 16:05 jasonqiu212