teammates icon indicating copy to clipboard operation
teammates copied to clipboard

[#12679] & [#12653] Copying feedback session: Name for copied session should not be whitespace & Copy course modal: Mandatory fields not highlighted

Open Josephine0110 opened this issue 10 months ago • 2 comments

Fixes #12679 Fixes #12653

Outline of Solution

For Issue#12679 Added a validator to copy session component, checking whether the feedback session name is whitespace or not. If the Name for feedback session is only composed of whitespace, the red warning of "The field "Name for copied session" should not be empty." would appear on the screen.

Before: (from the issues) image

After: Screenshot 2024-04-21 at 2 43 56 PM

For Issue#12653 Modified frontend to make the user input of Course ID and Course Name mandatory by adding a red warning sign down the input box

Before: image

After: image

Josephine0110 avatar Apr 21 '24 21:04 Josephine0110

Hi @Josephine0110, thank you for your interest in contributing to TEAMMATES! However, your PR does not appear to follow our contribution guidelines:

  • Title must start with the issue number the PR is fixing in square brackets, e.g. [#<issue-number>]

Please address the above before we proceed to review your PR.

github-actions[bot] avatar Apr 21 '24 21:04 github-actions[bot]

@Josephine0110 Do fix the failing tests. You can find out more about how to update tests in our documentation

weiquu avatar Jun 29 '24 07:06 weiquu

Folks, This PR seems to be stalling (no activities for the past 7 days). :snail: :cry: Hope someone can get it to move forward again soon...

nusoss-bot avatar Jul 06 '24 14:07 nusoss-bot

Hi @Josephine0110 could you please fix the failing component tests? Do let us know if you need any help

domoberzin avatar Jul 10 '24 14:07 domoberzin

Folks, This PR seems to be stalling (no activities for the past 7 days). :snail: :cry: Hope someone can get it to move forward again soon...

nusoss-bot avatar Jul 17 '24 16:07 nusoss-bot

Folks, This PR seems to be stalling (no activities for the past 9 days). :snail: :cry: Hope someone can get it to move forward again soon...

nusoss-bot avatar Jul 19 '24 16:07 nusoss-bot

Folks, This PR seems to be stalling (no activities for the past 8 days). :snail: :cry: Hope someone can get it to move forward again soon...

nusoss-bot avatar Jul 28 '24 03:07 nusoss-bot

Hi @Josephine0110,

I've noticed there hasn't been any activity on this PR for awhile. Are you still working on this? If you need any help or have decided not to continue, please let us know so someone else may pick up this issue to keep things moving.

Thank you for your contribution!

domoberzin avatar Jul 28 '24 04:07 domoberzin

@Josephine0110 closing due to inactivity, please reopen when ready!

mingyuanc avatar Jul 30 '24 15:07 mingyuanc