teammates icon indicating copy to clipboard operation
teammates copied to clipboard

Users with deadline extensions may not be able to submit feedback responses in V9

Open jayasting98 opened this issue 1 year ago • 1 comments

The V9 version of verifySessionOpenExceptForModeration checks if the session is open, but it may not be checking if the session is open given a deadline.

https://github.com/TEAMMATES/teammates/blob/5b3a96fdde95d6ab3fef6b861c2867efe92d15f4/src/main/java/teammates/ui/webapi/BasicFeedbackSubmissionAction.java#L313-L319

Note that the code is similar to the pre-V9 version, but the difference is that FeedbackSessionAttributes::isOpened checks the deadline extension, while teammates.storage.sqlentity.FeedbackSession::isOpened does not check the deadline extension.

https://github.com/TEAMMATES/teammates/blob/5b3a96fdde95d6ab3fef6b861c2867efe92d15f4/src/main/java/teammates/common/datatransfer/attributes/FeedbackSessionAttributes.java#L330-L333

https://github.com/TEAMMATES/teammates/blob/5b3a96fdde95d6ab3fef6b861c2867efe92d15f4/src/main/java/teammates/storage/sqlentity/FeedbackSession.java#L466-L469

(The bug was spotted in the code, not in production, so the following does not apply.)

~~- Environment:~~

~~Steps to reproduce~~

~~Expected behaviour~~

~~Actual behaviour~~

~~Additional info~~

jayasting98 avatar Feb 23 '24 04:02 jayasting98

To add, any action that relies on verifySessionOpenExceptForModeration where deadline extensions apply may also be affected, such as (Create|Update|Delete)FeedbackResponseCommentAction.

jayasting98 avatar Feb 23 '24 06:02 jayasting98