teammates icon indicating copy to clipboard operation
teammates copied to clipboard

[#12329] Refactoring of sortable tables - notifications table

Open domoberzin opened this issue 1 year ago • 1 comments

Part of #12329

Outline of Solution This PR refactors the notification-table component under the admin pages to utilize the sortable-table component. Implementation details follow previously merged PRs for different components in the same issues, with the change highlighted below.

Addition of Class and Tooltip options to SortableTableCellData

  • This is required to maintain the behavior of the original notifications table, where there are tooltips for the columns with dates. This change is likely to allow more flexibility in the use of sortable tables as well, though this is applied on a cell-by-cell basis.

The notification table maintains more or less the same visual appearance and functionality as it did before these changes.

domoberzin avatar Feb 01 '24 13:02 domoberzin

Hi @domoberzin, thank you for your interest in contributing to TEAMMATES! However, your PR does not appear to follow our contribution guidelines:

  • Title must start with the issue number the PR is fixing in square brackets, e.g. [#<issue-number>]

Please address the above before we proceed to review your PR.

github-actions[bot] avatar Feb 01 '24 13:02 github-actions[bot]

Folks, This PR seems to be stalling (no activities for the past 74 days). :snail: :cry: Hope someone can get it to move forward again soon...

nusoss-bot avatar Jul 01 '24 13:07 nusoss-bot

Folks, This PR seems to be stalling (no activities for the past 7 days). :snail: :cry: Hope someone can get it to move forward again soon...

nusoss-bot avatar Jul 08 '24 14:07 nusoss-bot

@domoberzin pls pass failing CI

mingyuanc avatar Jul 10 '24 12:07 mingyuanc

Folks, This PR seems to be stalling (no activities for the past 7 days). :snail: :cry: Hope someone can get it to move forward again soon...

nusoss-bot avatar Jul 17 '24 16:07 nusoss-bot

Folks, This PR seems to be stalling (no activities for the past 9 days). :snail: :cry: Hope someone can get it to move forward again soon...

nusoss-bot avatar Jul 19 '24 16:07 nusoss-bot

Folks, This PR seems to be stalling (no activities for the past 8 days). :snail: :cry: Hope someone can get it to move forward again soon...

nusoss-bot avatar Jul 28 '24 03:07 nusoss-bot

Closing this as it is stale, will re-open in future

domoberzin avatar Jul 28 '24 04:07 domoberzin