teammates icon indicating copy to clipboard operation
teammates copied to clipboard
verified publisher icon TEAMMATES

Add Sort Functions to Admin Sessions Page

Open sxw022020 opened this issue 2 years ago • 12 comments

Description of feature/enhancement Add “Sort” features to AdminSessions-OngoingSessions:

  • “Sort” features:
    • Sort by “Start Time”, “End Time”, “University Name”, and “The Number of Open Sessions a University Has”

Justification

Keep the format consistent and let administer would have a more clear understanding of sessions

Existing similar features and their shortcomings

Screenshot 2023-06-06 at 10 47 26 AM
Instructor Home has a similar format but with sort features

sxw022020 avatar Jun 06 '23 17:06 sxw022020

Hey @sxw022020 , Is this issue available, I would like to work on it.

sumitdethe27 avatar Jun 08 '23 17:06 sumitdethe27

Hi @sumitdethe27, @sxw022020 has already submitted a PR for this issue. I suggest you take a look at other issues, perhaps those tagged as good first issue.

weiquu avatar Jun 09 '23 08:06 weiquu

Okay @weiquu Thankyou.

sumitdethe27 avatar Jun 09 '23 11:06 sumitdethe27

Hey @weiquu can I take up this one?

singhabhyudita avatar Jun 23 '23 02:06 singhabhyudita

@singhabhyudita, sure please go ahead

weiquu avatar Jun 25 '23 00:06 weiquu

Hi @weiquu is it necessary to use the sortable-table component for this? I am asking because the format of the sessions table in admin sessions page is quite different from the sortable-table component format. I think it can be done using the component but it will be simpler if we do it without it.

singhabhyudita avatar Jun 28 '23 22:06 singhabhyudita

Hi @singhabhyudita, I'll only have time to take a closer look this weekend... in the meantime, could you highlight some of the issues faced? I think that would also be useful when we're refactoring other pages. Would of course prefer if the sortable-table component is used, since I believe that's the more extensible approach (and we can abstract away the sorting functions)

weiquu avatar Jun 29 '23 07:06 weiquu

I will try to implement it using the component and will let you know.

singhabhyudita avatar Jun 29 '23 07:06 singhabhyudita

Is someone still working on this? Or can i take it up?

sawilkhan avatar Jul 06 '23 09:07 sawilkhan

I am working on it and am about to open a PR for this soon. Thanks.

singhabhyudita avatar Jul 06 '23 09:07 singhabhyudita

I would like to work on it:)

Sheepfan0828 avatar Oct 17 '23 06:10 Sheepfan0828

PR may have bugs

anjum-edge avatar Oct 20 '23 11:10 anjum-edge