teammates
teammates copied to clipboard
TEAMMATES
Instructors with custom permissions cannot reach the session results page
v8.19.2, production, reported by a user
Scenario: An instructor has been given permission to view responses of a specific section only. See below for an example:
Problem: When that instructor tries to view results of the session, the following error shows up:
I suspect this is because the instructor doesn't have permission to see all results of the session.
Admittedly, the permission-checking code at this page (both versions) is quite a mess. But just to get the record straight, this is the course-wide page?
Admittedly, the permission-checking code at this page (both versions) is quite a mess. But just to get the record straight, this is the course-wide page?
Yes, it is a course-wide results page. The course owner figured out a workaround, by setting the permissions in this way instead:
In this case the tutor can see the results, as long as he selects the correct section here:
@tau-bar Go ahead, but do keep us in the loop as @wkurniawan07 has mentioned that the checks are in this page might be messy
@damithc Although I'm not very sure, based on the phrasing in the UI, probably the workaround is actually the correct way to set things. Looking at the page, it says "In general, this instructor can ... but in sections ... this instructor can only ...". From my interpretation, the word "only" seems to imply something more restrictive. So it's probably supposed to mean in order for the instructor to have permission A for section B, he must have permission A at both the course level and for section B, provided section B permissions are set separately. In other words, if the instructor doesn't have a permission at the course level (or so-called "in general"), any permission given at section level is useless. With that said, I'm not really sure what's the expected flow when this page was designed previously but things should be consistent here if we are making any changes so that users won't be more confused. We should also refine the whole permission setting and checking part to make it clearer some time.
@fans2619 You are right in that the the current behavior seems to agree with the UI. For practical purposes though, we need to support both approaches, or switch to the other approach. This is because the more common scenario is a tutor is given access to her own section only. That is, number of inaccessible sections could be a lot more than accessible sections, making the configuration very verbose. e.g., 15 sections with 15 tutors will require 225 separate access configurations. What do you think?
@fans2619 @damithc Perhaps a more accurate way to phrase it would be to say "~~But~~ In sections... this instructor can only...", so that the UI would be consistent with the logic? Since as mentioned, the more common scenario is for the tutor to only be given access to their own section. However, I believe issue #11935 needs to be resolved as well before this proposed UI would entirely match the logic of the custom settings.
we need to support both approaches, or switch to the other approach
I totally agree with this.
@fans2619 @damithc Perhaps a more accurate way to phrase it would be to say "~But~ In sections... this instructor can only...", so that the UI would be consistent with the logic?
Yup. Perhaps remove only as well.