teammates icon indicating copy to clipboard operation
teammates copied to clipboard

Show loading message below response loading spinner

Open moziliar opened this issue 3 years ago • 14 comments

From PR #10960

Description of feature/enhancement

If a course has many students (or in general many responses per question), add extra loading text below the spinner to inform the user that the students are being loaded (after perhaps 5s).

image

Justification

From @damithc

Provided the load operation will not time out, perhaps simply show a message below the spinner cautioning the user that this particular question will take a long time to load?

This would give user more assurance that there is progress in the loading.

Existing similar features and their shortcomings

Experimented with using forkJoin in the frontend to fetch questions in parallel in #10960: the parallel calls create too much instantaneous load at the backend and causes new instances to be spun up. The cost here is not justified.

moziliar avatar Feb 27 '21 07:02 moziliar

I will take this issue

dastansultanov avatar Mar 10 '21 11:03 dastansultanov

Hi. Is this issue resolved? Or anyone working still on it?

anshuman-dev avatar Mar 17 '21 04:03 anshuman-dev

@anshuman-dev Priority will be given to the previous commenter as they have a PR up. You can try to find another good first issue to work on

t-cheepeng avatar Mar 17 '21 09:03 t-cheepeng

Is this issue resolved?

P-Fabian avatar Nov 12 '21 00:11 P-Fabian

Is the issue resolved? I would like to take this up.

shivamsharma01 avatar Jan 16 '22 16:01 shivamsharma01

@shivamsharma01 The issue is still open, you can work on it

ypinhsuan avatar Jan 18 '22 02:01 ypinhsuan

@shivamsharma01 The issue is still open, you can work on it

I am not able to setup the project properly and getting some errors. Can anyone please assist?

While trying to run gradlew.bat serverRun getting the below error 2022-01-18 13:55:13.363:WARN:oejw.WebInfConfiguration:main: Web application not found D:\Open%20Source\teammates\build\exploded-teammates

Also, on the UI when i try to login as student or instructor i am getting the below error on console Access to XMLHttpRequest at 'http://localhost:8080/webapi/auth?frontendUrl=http://localhost:4200' from origin 'http://localhost:4200' has been blocked by CORS policy: Response to preflight request doesn't pass access control check: No 'Access-Control-Allow-Origin' header is present on the requested resource.

shivamsharma01 avatar Jan 18 '22 09:01 shivamsharma01

@shivamsharma01 Hi, for the first error it may be because your folder Open Source contains a space in the folder name? Maybe can try changing the folder name to OpenSource or something that do not contain a space.

hhdqirui avatar Jan 19 '22 16:01 hhdqirui

Is this issue still open? I would like to work on it.

arnavk1872 avatar Mar 01 '22 12:03 arnavk1872

Yes, probably. I was able to setup the workspace with the help of @hhdqirui 's suggestions but now I am not able to login to the application. Don't know how to create a user.

shivamsharma01 avatar Mar 01 '22 13:03 shivamsharma01

Can I also attempt working on this issue if it's still not resolved?

rom-me avatar Mar 04 '22 12:03 rom-me

@rom-me Hi, please look for another issue to work on as there are previous users who wish to tackle this

t-cheepeng avatar Mar 05 '22 04:03 t-cheepeng

@shivamsharma01 you can refer to https://github.com/TEAMMATES/teammates/blob/master/docs/development.md to see how to create users

t-cheepeng avatar Mar 05 '22 04:03 t-cheepeng

In my understanding, there is a switch between the loading-spinner component (via loading-spinner directive) and the templateref using ngIf directive. There is no direct way to show the message while the loader is being displayed through the parent component. I have added the logic to display 'Loading Records...' after 5 seconds but this is now not limited to records being loaded in the feedback page but every time the loader component is visible for more than 5 seconds on any screen. Kindly let me know if instead this should be limited to only a specific case and any suggestions to handle it.

image

shivamsharma01 avatar Mar 06 '22 00:03 shivamsharma01

Can I take this issue?

hlee18lee46 avatar Oct 03 '22 03:10 hlee18lee46

@hlee18lee46 Go ahead!

NicolasCwy avatar Oct 04 '22 04:10 NicolasCwy

Can I work on this issue, or is it already assigned to someone?

prakritishetty avatar Oct 07 '22 10:10 prakritishetty

@PrakritiShetty Someone else has taken it. Please find other issues to work on instead!

fsgmhoward avatar Oct 07 '22 11:10 fsgmhoward

Assign this issue to me

sumit970 avatar Feb 15 '23 20:02 sumit970

Assign this issue to me

Our Development Workflow can be found here.

samuelfangjw avatar Feb 16 '23 01:02 samuelfangjw

@sumit970 Hey! Are you still working on this? If not, I'd like to work on it

asn001013 avatar Mar 12 '23 07:03 asn001013

Hi, I would like to take this issue up

MMilou24 avatar Mar 28 '23 13:03 MMilou24

@sumit970 Hello, are you still working on this issue? If not, we can have others to take this up.

@MMilou24 Hey there! Let's give @sumit970 some time to respond. If not, you may look at other issues here for first time contributors.

domlimm avatar Mar 28 '23 14:03 domlimm

hey you can work on it.

sumit970 avatar Mar 28 '23 18:03 sumit970

@sumit970 Thanks for getting back! Much appreciated.

@MMilou24 Feel free to work on this issue.

domlimm avatar Mar 29 '23 01:03 domlimm

@MMilou24 and I are working on this together for a university course, therefore I have created the pull request.

nielsly avatar Mar 31 '23 16:03 nielsly