teammates
teammates copied to clipboard
TEAMMATES
Missing loading icons and bugs
Missing loading icons for Instructor Session Management page
Instructor Sessions Page
- [ ] All buttons under "Deleted Feedback Sessions" table (Defer for now. see https://github.com/TEAMMATES/teammates/issues/11162)
- [ ] Under new session form: "Copy from previous feedback sessions" button (Defer for now. see https://github.com/TEAMMATES/teammates/issues/11162)
- [ ] Under active session table (Defer for now. see https://github.com/TEAMMATES/teammates/issues/11162)
- [ ] Delete button
- [ ] Copy button
- [ ] Remind button: Both on click and after confirming remind
- [ ] All buttons under "Results" dropdown menu
Instructor Session Edit Page
- [x] Session Edit Form
- [x] Clicking save at the top of the session edit form does not show loading icon at the upper save button. Only the lower "Save Changes" button have a loading icon
- [x] Delete button
- [ ] Copy button: Both on click and after confirming copy (Loading icon is implemented, but there's a small bug here: loading icon should not persist both after modal is shown, and after modal is cancelled)
- [x] Question Edit Form
- [x] Delete button
- [x] Duplicate button
- Somehow loading icon appears on the "Save Changes" button instead, when the duplicate button is clicked
- [x] Add New Question -> Choose from template question
Raising priority to medium because when the loading time gets long, there is nothing stopping the user from navigating away or clicking other buttons thinking nothing is happening.
Raising priority to medium because when the loading time gets long, there is nothing stopping the user from navigating away or clicking other buttons thinking nothing is happening.
This has nothing to do with whether there is loading icon or not?
I think it's more like the user is more likely to navigate away if there is no loading icon.
we are a team of of developers , we would like to work on this issue #10569 . can we proceed?
we are a team of of developers , we would like to work on this issue #10569 . can we proceed?
Sure, you're welcome to give it a go. I would recommend separate PRs for individual components, you can tag them as "Part of" this PR (see process.md). Let us know if you need any help.
The "View Results" button under "Results" drop down menu seems to already have a loading icon for when the View Results page populates. Will the spinner that is already present suffice or should I had another one?
Problem Introduction: I have solved the bullet points under the session edit form. However, there is one component test (BuildPropertiesTest) that isn't passing. It doesn't pass in either my local master or my local working branch so I think it may be an environment issue.
What I have tried to fix the failing test: I noticed some of the "build.template.properties" files had additional content that the "build.properties" files didn't have so I copied the template files and named the copy "build.properties". However, the test still fails.
Does anyone have any insight that will help me with this?
Here is a screenshot of the test failing:
@jfrairigh it's best to create a new issue in the tracker with your request for help, that way we can discuss it there and close the issue after your problems have been resolved
For now you can try running Step 3 of https://github.com/TEAMMATES/teammates/blob/master/docs/setting-up.md and if this doesn't resolve your issue just create a new issue in the tracker yea
I'm currently working on the remainder of the bullet point items for this issue. One of the items under Question Edit Form states, "Loading icon on save is too close to the tick icon on the save button". Here is a screenshot of how it looks currently:
How would you like it to look? To me, it currently looks the same as the spinner alignment on the buttons in the Session Edit Form.
I believe that portion has been addressed in a separate PR actually. @damithc current spacing okay? Between the tick and the loading icon in the above screenshot.
I believe that portion has been addressed in a separate PR actually. @damithc current spacing okay? Between the tick and the loading icon in the above screenshot.
My expectations was the spinner will appear in place of the tick, and will be replaced by the tick when the work is done. Would that be better? That way, the button size can remain the same. OK if it's too late to go that way (i.e., if a different approach has been taken in other places already). Plus, I would like to see a gif or a screen recording of how it actually appears in action.
Here is a video of how the save spinner in the Question Edit Form currently looks: https://drive.google.com/file/d/1QVPQP_OS0krRKW23qKPm94Ow4NL7LR_C/view?usp=sharing
The delete, copy, and upper save buttons in the Session Edit Form look the same way.
Should I continue with the same style or is it better to change styles by removing the icons and replacing them with the spinners?
change styles by removing the icons and replacing them with the spinners
If it is not too troublesome, I'd say this is preferred as the tick is kind of redundant when the spinner appears.
Here is a video of how the save spinner in the Question Edit Form currently looks: https://drive.google.com/file/d/1QVPQP_OS0krRKW23qKPm94Ow4NL7LR_C/view?usp=sharing
@jfrairigh tip: you can embed the video here itself, just like screenshots. Just drop the file into the comment box.
Hi, I am on the session edit form and I tried to redo the bug that you stated here:
Copy button: Both on click and after confirming copy (Loading icon is implemented, but there's a small bug here: loading icon should not persist both after modal is shown, and after modal is cancelled)
But it seems that the bug is not existing anymore. After the modal is shown and cancelled, there are no loading icons anymore.
Hi, may I be assigned to this issue? I would like to work on Instructor Sessions Page, delete button.
@Lucas-longxutang Hello, we do not assign issues to contributors. Feel free to submit a PR for this issue! 😄
