Thierry Ducrest

Results 70 comments of Thierry Ducrest

@grindtildeath Could you squash and see if the pre-commit still have an issue, thanks

Thanks @grindtildeath CI is :green_heart: again Squash and merge next ?

> no need to update tests? I have added 2 in relation to the changes

> LG :) Can you squash fixups? Done

> @TDu I have two questions on this as it seems to have not been integrated in OCA module: > > * The grouping mode and the invoicing mode on...

> I find it strange to return ids and not recordset True, I did not want to browse for the records when not needed.

> @TDu Prefer explicit naming `sale_stock` in commit message: > > ![image](https://private-user-images.githubusercontent.com/19529533/364312664-62886d60-decf-49bc-ad27-c44e00042c5f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU2MjUzOTUsIm5iZiI6MTcyNTYyNTA5NSwicGF0aCI6Ii8xOTUyOTUzMy8zNjQzMTI2NjQtNjI4ODZkNjAtZGVjZi00OWJjLWFkMjctYzQ0ZTAwMDQyYzVmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MDYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTA2VDEyMTgxNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWU1NDZmNDY0YjU4NTE4YjI2N2VmMGYzMmRiMWNjMGZlYjlmZGFjM2RkNmE2MzRlYWNkZjk1Nzg0YTVlZGM5NmUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0._udcFr-zSkxcNPren3JbT6HI55FL8oCnOVHNZyl4fug) I updated the commit message. Always a juggle :juggling_person: between the length and the meaning on the title...

> > I updated the commit message. Always a juggle 🤹 between the length and the meaning on the title of the commit message. > > But the module name...