Tyler Holmes comments

Results 71 comments of


                                            Tyler Holmes

Use `#[doc(cfg(...))]`

It looks like this is getting superseded by this automatically happening for us: https://github.com/rust-lang/rust/pull/89596

Use `#[doc(cfg(...))]`

Once https://github.com/rust-lang/rust/issues/43781 lands, we should get this for free if I'm understanding things properly

DWT: differentiate the first comparator

Thanks for opening this so we don’t forget. IIRC, the second comparator is also special (specific for data compare? I don’t recall the exact details) On Sat, Jan 1, 2022...

DWT: differentiate the first comparator

🏷️ #367 (the cycle count PR)

DWT: differentiate the first comparator

I was wrong, only comparator zero is special. Opened up a PR

rust-lld: error: undefined symbol: fmodf

Looks like it's all merged into compiler builtins

Spelling `NOM`

NUM could be confused for number so a slight misspelling to keep it short and clear makes sense to me

HTTP 403 from the tool cache

from tools-cache README: > ### Deprecation warning > > It is archived now and will not be updated anymore. actions-rs/install Action will be updated eventually to utilize GitHub runners cache...

1 fewer bars in bar chart than expected

does using an x range of 0 to 6 work?

Made lib no-std

This was discussed on #14 , how are you handling `drawile-rs` & `colored`? Those are `std` reliant dependencies aren't they?