stumpy icon indicating copy to clipboard operation
stumpy copied to clipboard

[WIP] #685 Tutorial on Novelets

Open NimaSarajpoor opened this issue 3 years ago • 4 comments

This addresses issue #685, Novelet Notebook. I was talking about this paper with one of my friends, and I decided to implement it. And, then I decided to create a notebook and push it here.

I have not reproduced the figures yet. For now, I just tried to provide the gist of paper and implement the algorithm and show the result.

Next steps:

  • Check out MATLAB code to ensure the authors remain faithful to the algo provided in the paper
  • Reproduce figures

NimaSarajpoor avatar Oct 14 '22 18:10 NimaSarajpoor

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Codecov Report

Base: 99.60% // Head: 99.60% // No change to project coverage :thumbsup:

Coverage data is based on head (8a623e3) compared to base (ac238b6). Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #692   +/-   ##
=======================================
  Coverage   99.60%   99.60%           
=======================================
  Files          81       81           
  Lines       12758    12758           
=======================================
  Hits        12707    12707           
  Misses         51       51           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov-commenter avatar Oct 14 '22 19:10 codecov-commenter

@seanlaw side note: the error raised here might be one of those (easy-to-resolve?) cases that might be resolved by the following:

  • setting config variable STUMPY_STDDEV_THRESHOLD to smaller value: 1e-20
  • refine std calculation if it is less than 1.0 (recall that this can mean not taking advantage of rolling std when we have T = np.random.rand() as std will be definitely less than 1.0

(OR, It might be one of those hard cases where cov becomes very small)

NimaSarajpoor avatar Oct 14 '22 19:10 NimaSarajpoor

Thanks @NimaSarajpoor. Looks good

seanlaw avatar Oct 15 '22 00:10 seanlaw