stumpy icon indicating copy to clipboard operation
stumpy copied to clipboard

[WIP] Dev Tutorial for STUMP Tiles Algorithm

Open alvii147 opened this issue 3 years ago • 8 comments
trafficstars

Pull Request Checklist

Below is a simple checklist but please do not hesitate to ask for assistance!

  • [x] Fork, clone, and checkout the newest version of the code
  • [x] Create a new branch
  • [x] Make necessary code changes
  • [x] Install black (i.e., python -m pip install black or conda install -c conda-forge black)
  • [x] Install flake8 (i.e., python -m pip install flake8 or conda install -c conda-forge flake8)
  • [x] Install pytest-cov (i.e., python -m pip install pytest-cov or conda install -c conda-forge pytest-cov)
  • [ ] Run black . in the root stumpy directory
  • [ ] Run flake8 . in the root stumpy directory
  • [ ] Run ./setup.sh && ./test.sh in the root stumpy directory
  • [x] Reference a Github issue (and create one if one doesn't already exist)

alvii147 avatar Jan 30 '22 16:01 alvii147

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@seanlaw here's a first draft of what the first half of the tutorial might look like. I'm still nowhere near done with this, it's still a work in progress. Started a PR for some early feedback, lemme know if you have any comments!

alvii147 avatar Jan 30 '22 16:01 alvii147

Codecov Report

Merging #535 (1f8b46d) into main (5ac214f) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #535   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           35        35           
  Lines         2861      2861           
=========================================
  Hits          2861      2861           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5ac214f...1f8b46d. Read the comment docs.

codecov-commenter avatar Jan 30 '22 16:01 codecov-commenter

@alvii147 Excellent work overall! I've left some comments and I'm also curious what you are using to create animations?

seanlaw avatar Jan 30 '22 18:01 seanlaw

@seanlaw thanks for the feedback! I'll make appropriate changes. Once we finalize the stump_tiles module I can add more details.

I'm also curious what you are using to create animations?

I've just been using draw.io to draw the animation frames. Do you have any suggestions for better software?

alvii147 avatar Jan 31 '22 01:01 alvii147

I'm impressed! I didn't know that you could create animations wit draw.io.

seanlaw avatar Jan 31 '22 01:01 seanlaw

I didn't know that you could create animations wit draw.io.

You can't... I've just been drawing the frames 👀

alvii147 avatar Jan 31 '22 03:01 alvii147

😮 Your dedication and patience is noted and appreciated!

seanlaw avatar Jan 31 '22 03:01 seanlaw

@seanlaw I think this can be archived as well

alvii147 avatar Aug 16 '23 18:08 alvii147

@seanlaw closing as it is blocked by #709

alvii147 avatar Aug 23 '23 16:08 alvii147