Tom

> Based on [this test setup](https://github.com/erlang/otp/blob/4ece5771e493186dc88b4641090229a6cabd2a37/lib/dialyzer/test/incremental_SUITE.erl#L1038) from OTP, and the [original commit message](https://github.com/erlang/otp/commit/963c7d5ccecb9ea4940e7112d88534781a413fa6) I'm assuming --apps and --warning-apps have to overlap. I'm not sure how I missed this before. That...

This is true. Perhaps my example was too simplified to show the value of the optimiser in general. Consider a case where we don't have a literal `42`, but instead...

> Some code style comments: I'm not fond of white space fixes in otherwise untouched lines. I would prefer them in a separate commit if you want to keep them....

> Would this optimisation also impact tracing, or is the functionality too different to matter in the way match specs are run in this case? I don't know how tracing...

> There are a bunch of failing test cases in qlc_SUITE > > They seem to be triggered by this PR, but I haven't investigated further. @sverker: Good find! I...

> Was the merging of master to fix conflicts? It seems like CI fails to build due to some sort of caching issue when I base this change on `maint`...

> It would be nice if you could write something in `ets:fun2ms` docs about this. Maybe use the new `` tag when talking about difference in behavior between OTP versions...