web5-js icon indicating copy to clipboard operation
web5-js copied to clipboard

Use the updated `select_credentials` test vector

Open jiyoontbd opened this issue 2 months ago • 0 comments

Currently, consuming select_credentials.json test vectors in this repo results in failure for the test vectors with these descriptions:

  1. select credentials for presentation, multiple input descriptors, not all of them are satisfied
  2. select credentials for presentation, using array filter

We should consider these two things:

  1. Is the test vector asserting the correct output?
  2. If answer to 1 is yes, is the selectCredentials() implementation making incorrect assumptions?
  3. Overall, are we interpreting the PEX spec correctly?

The possible outcomes of this issue is that we address the failures by either changing the implementation or changing the test vector.

jiyoontbd avatar May 03 '24 00:05 jiyoontbd