dwn-sdk-js

dwn-sdk-js copied to clipboard

Create GH issues for each TODO in codebase and link the corresponding issue number (eg. #123)

3

For each `// TODO:` in codebase: - create respective GH issue - reference issue # next to each TODO in codebase

mistermoe

Declare proper typing for `includeCriteria` and `excludeCriteria` in MessageStore and MessageStoreLevel

1

Change type of `query` https://github.com/TBD54566975/dwn-sdk-js/blob/fcea84929e12dd3e3ef0e8866b0e592a025786fa/src/store/message-store.ts#L32-L34

bnonni

Replace with JSON Schema based validation for `JsonWebKey2020`. More info about the `JsonWebKey2020` type can be found here: https://www.w3.org/TR/did-spec-registries/#jsonwebkey2020 https://github.com/TBD54566975/dwn-sdk-js/blob/fcea84929e12dd3e3ef0e8866b0e592a025786fa/src/jose/jws/general/verifier.ts#L66-L73

bnonni

Replace verificationMethod checks with JSON Schema based validation (publicJwk)

1

Replace with JSON Schema based validation for `publicJwk`. More info about the `publicJwk` property can be found here: https://www.w3.org/TR/did-spec-registries/#publicJwk https://github.com/TBD54566975/dwn-sdk-js/blob/fcea84929e12dd3e3ef0e8866b0e592a025786fa/src/jose/jws/general/verifier.ts#L74-L84

bnonni

Add cache support to avoid costly validation of the same signature

1

Add logic to prevent validating duplicate signatures https://github.com/TBD54566975/dwn-sdk-js/blob/fcea84929e12dd3e3ef0e8866b0e592a025786fa/src/jose/jws/general/verifier.ts#L14-L44

bnonni

Explicit check to ensure only 1 signer

2

Should we add an explicit check to ensure that there's only 1 signer? https://github.com/TBD54566975/dwn-sdk-js/blob/fcea84929e12dd3e3ef0e8866b0e592a025786fa/src/interfaces/permissions/handlers/permissions-request.ts#L21-L28

bnonni

Figure out if support needed for all W3 verification method properties

1

Figure out if we need to support ALL verification method properties. https://github.com/TBD54566975/dwn-sdk-js/blob/fcea84929e12dd3e3ef0e8866b0e592a025786fa/src/did/did-resolver.ts#L97-L112

bnonni

Current requester DID validation uses naive technique. Add better DID validation. https://github.com/TBD54566975/dwn-sdk-js/blob/fcea84929e12dd3e3ef0e8866b0e592a025786fa/src/did/did-resolver.ts#L26-L33 Proposed changes in PR https://github.com/TBD54566975/dwn-sdk-js/pull/60. New function `validateDID(did)`: https://github.com/TBD54566975/dwn-sdk-js/blob/e9b76bc7c45115d4c4577c1369bd46a6da9b64f2/src/did/did-resolver.ts#L26-L30 Function implementation: https://github.com/TBD54566975/dwn-sdk-js/blob/e9b76bc7c45115d4c4577c1369bd46a6da9b64f2/src/did/did-resolver.ts#L53-L68

bnonni

Add cache support to DidResolver

9

Add DIDCache to constructor method signature. https://github.com/TBD54566975/dwn-sdk-js/blob/fcea84929e12dd3e3ef0e8866b0e592a025786fa/src/did/did-resolver.ts#L9-L17

bnonni

Use typescript utility types to define the index search instance

2

A better solution would be for `@types/search-index` to be updated and have the types exported. But until that is done, using the inbuilt typescript util types works. A type error...

NWylynko