dwn-sdk-js icon indicating copy to clipboard operation
dwn-sdk-js copied to clipboard

Make `maxDataSizeAllowedToBeEncoded` configurable

Open diehuxx opened this issue 10 months ago • 3 comments

Maybe add a config to Dwn#create.

diehuxx avatar Sep 22 '23 23:09 diehuxx

Is this just so it's easier to change as we settle on something?

csuwildcat avatar Sep 22 '23 23:09 csuwildcat

No, more that I don't see why we (contributors to this repo) need to settle on a single value at all. I can imagine developers wanting to tweak it different ways depending on what underlying data store they use.

This isn't a hill I'm trying to die on, just something that crossed my mind.

diehuxx avatar Sep 22 '23 23:09 diehuxx

The theory for maintaining the same constant across different store implementations was to provide developers with consistent expectations, potentially simplifying their code by reducing the number of conditions they need to consider. But this is still just a theory.

thehenrytsai avatar Sep 25 '23 19:09 thehenrytsai