Integrate pre-commit

Open daico007 opened this issue 3 years ago • 2 comments

On the previous PR (now merged), I noted that there were several flake8 related issue. For open-source library, I think it would be nice to integrate pre-commit hook to ensure the code-styles of the library are consistent (https://pre-commit.com/), especially if you are expecting external contributors.

Nov 29 '22 18:11 daico007

If you like the idea, I can implement it in a PR (I got a pre-commit template from my project).

Nov 29 '22 18:11 daico007

thanks, currently I run flake8 metabci/ --per-file-ignores="__init__.py:F401" --extend-ignore=E203,W605 --max-line-length=127 --statistics --count and mypy metabci/ --ignore-missing-imports before git commit. your pr will be helpful

Dec 01 '22 03:12 miyanyan