Paul "TBBle" Hampson

Results 386 comments of Paul "TBBle" Hampson

> Similar case appears here. Failure from try-finally block is never handled. > > https://github.com/adamrehn/ue4cli/blob/fed71c1af4cffe3fed9358b08430068ad9454b77/ue4cli/UE4BuildInterrogator.py#L165-L176 This one's a bit different, it's just letting any exceptions propagate up (for better or...

My understanding of the issue was for non-Windows platforms. It's possible Linux doesn't even _have_ the concept of an Installed Build registry because there's no EGS or Binary distribution. And...

At least for 2, my feeling is that I'd prefer `ue4 setroot ` to be an _override_ option, and if I haven't used it (or call `ue4 clearroot`), then it...

I would guess that this wasn't done earlier because `ue4 setroot` has been good enough for everyone (including me, as I never implemented this idea either), and possibly because the...

To me, and again speaking from more-recent Go experience, the advantage of wrapping the exception at the time it enters out domain is that we can add detail about what...

So I've just hit another corner-case related to this request. The UE Shooter Game example includes the following: * ShooterGame.uproject * Source/ShooterClient.Target.cs * Source/ShooterGame.Target.cs * Source/ShooterGameEditor.Target.cs * Source/ShooterServer.Target.cs Using `ue4...

I didn't try, but I strongly suspect more tooling than just ue4cli will barf on that, when it tries to assemble a target name from the project and target type....

As a follow-up, `ue4 package -client -noserver` and `ue4 package -noclient -server` has no problems with the Shooter Game's target layout. I assume UAT `BuildCookRun` discovers targets by looking at...

I do think this is a bug. Quoting [the OCI Image spec](https://github.com/opencontainers/image-spec/blob/v1.0.2/layer.md#non-distributable-layers): > Non-distributable layers SHOULD be tagged with an alternative mediatype of `application/vnd.oci.image.layer.nondistributable.v1.tar`. Implementations SHOULD NOT upload layers tagged...

If you put `${BUILD_NUMBER}` in particular into the name, then wouldn't you get a new job created for each build? Then a failed build once would mark the MR as...