Teemo Vaas

Results 60 comments of Teemo Vaas

@dantob Can you be more specific why the -O2 is now needed instead of -Os? I may have missed the discussion about that somwhere. Asking as a user of 407VE.

@dantob On blackpill (or stm32 in general) the loops per sec is so low because of blocking ADC is used (Most of the time it simply waits for the ADC...

According to the Speeduino style guide the variables should be "camelCase, lowercase first letter, no spaces or _" (https://wiki.speeduino.com/en/dev/Style_code).

Hi. Looked into this. Wihtout much prior knowledge about this part of the code, would there not be a good idea to use safety constrain when accessing array via dynamic...

It fails building for stm32 currently. Seems like there are problems with the `min() `function. So probably simple written out custom implementation of the `min()` functionality is needed.

I looked briefly, this currently do not include switching from full sync to half sync and back during the starting (semi sequential during half sync and then switching to full...

@noisymime I reviewed that PR also and it seems legit. When doing timing, it is correct way to calculate interval and compare the intevals, this way it is overflow proof...

Had a look, seems the changes in the PR is now outdated, because the code have changed so much meanwhile. Although seems the micros() misuse still exist in various places....

As far as I know currently the basic distributor or dual wheel decoder uses only one edge(rising or falling) as a reference. So it is perfectly possible to make a...

Quite a lot of changes for implementation of idea that seems quite easy to do by description... Though interested to hear about the tests on that. In some sence seems...