Tristan
Tristan
Thanks a lot for explanations, will be useful as this is my first Go contribution :)
@rodrigo-pino @cicr99 now all hints are implemented, we can discuss the scope of this issue should we replace big.Int absolutely everywhere its possible with uint256?
hey @danielcdz, sorru for the very late answer. sounds like a nice idea to me. Will make the code cleaner overall but it doesnt improve efficiency at all, it is...
just noticed this issue : https://github.com/NethermindEth/cairo-vm-go/issues/448 which basically suggests the same
Hi @Tomi-3-0 , do you have any update on this? I'd like to understand what the issue is exactly. You don't get the same result as the python cairo vm...
@Tomi-3-0 ok it's clear! Do you want to investigate and try with one or 2 other libraries? I can also work on it, as you prefer. If you find a...
@Tomi-3-0 ok great, will look into it tomorrow or the day after :) Could you just indicate me (if you remember) some values that didnt work?
hey @Tomi-3-0 I tried a few things and here is where I am : - currently, the implementation returns `P - result`, instead of `result` , both being a valide...
@Tomi-3-0 , the following implementation passes all the tests : ``` func newIsQuadResidueHint(x, y hinter.ResOperander) hinter.Hinter { return &GenericZeroHinter{ Name: "IsQuadResidue", Op: func(vm *VM.VirtualMachine, _ *hinter.HintRunnerContext) error { //> from...
i have not extensively test with the python vm for now. will do it in the weekend. yeah i added P-result computation to get the lowest valid result for the...